MicrosoftDocs / WindowsCommunityToolkitDocs

Creative Commons Attribution 4.0 International
179 stars 156 forks source link

[BrokenLinksH2] Fixed broken links #646

Open kturetz opened 2 years ago

opbld31 commented 2 years ago

Docs Build status updates of commit 836c7d6:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/controls/Menu.md :white_check_mark:Succeeded View
docs/controls/OrbitView.md :white_check_mark:Succeeded View
docs/controls/RadialGauge.md :white_check_mark:Succeeded View
docs/controls/RadialProgressBar.md :white_check_mark:Succeeded View
docs/controls/RangeSelector.md :white_check_mark:Succeeded View
docs/controls/RemoteDevicePicker.md :white_check_mark:Succeeded View
docs/controls/RotatorTile.md :white_check_mark:Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld31 commented 2 years ago

Docs Build status updates of commit c241f67:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/controls/Menu.md :white_check_mark:Succeeded View
docs/controls/OrbitView.md :white_check_mark:Succeeded View
docs/controls/RadialGauge.md :white_check_mark:Succeeded View
docs/controls/RadialProgressBar.md :white_check_mark:Succeeded View
docs/controls/RangeSelector.md :white_check_mark:Succeeded View
docs/controls/RemoteDevicePicker.md :white_check_mark:Succeeded View
docs/controls/RotatorTile.md :white_check_mark:Succeeded View
docs/controls/ScrollHeader.md :white_check_mark:Succeeded View
docs/controls/StaggeredPanel.md :white_check_mark:Succeeded View
docs/controls/TabView.md :white_check_mark:Succeeded View
docs/controls/TextToolbar.md :white_check_mark:Succeeded View
docs/controls/TileControl.md :white_check_mark:Succeeded View
docs/extensions/EnumValuesExtension.md :white_check_mark:Succeeded View
docs/extensions/Hyperlink.md :white_check_mark:Succeeded View
docs/extensions/LogicalTree.md :white_check_mark:Succeeded View
docs/extensions/MatrixExtensions.md :white_check_mark:Succeeded View
docs/extensions/MatrixHelperEx.md :white_check_mark:Succeeded View
docs/extensions/MouseCursor.md :white_check_mark:Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld32 commented 2 years ago

Docs Build status updates of commit e89defb:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/controls/Menu.md :white_check_mark:Succeeded View
docs/controls/OrbitView.md :white_check_mark:Succeeded View
docs/controls/RadialGauge.md :white_check_mark:Succeeded View
docs/controls/RadialProgressBar.md :white_check_mark:Succeeded View
docs/controls/RangeSelector.md :white_check_mark:Succeeded View
docs/controls/RemoteDevicePicker.md :white_check_mark:Succeeded View
docs/controls/RotatorTile.md :white_check_mark:Succeeded View
docs/controls/ScrollHeader.md :white_check_mark:Succeeded View
docs/controls/StaggeredPanel.md :white_check_mark:Succeeded View
docs/controls/TabView.md :white_check_mark:Succeeded View
docs/controls/TextToolbar.md :white_check_mark:Succeeded View
docs/controls/TileControl.md :white_check_mark:Succeeded View
docs/extensions/EnumValuesExtension.md :white_check_mark:Succeeded View
docs/extensions/Hyperlink.md :white_check_mark:Succeeded View
docs/extensions/LogicalTree.md :white_check_mark:Succeeded View
docs/extensions/MatrixExtensions.md :white_check_mark:Succeeded View
docs/extensions/MatrixHelperEx.md :white_check_mark:Succeeded View
docs/extensions/MouseCursor.md :white_check_mark:Succeeded View
docs/extensions/NullableBoolMarkup.md :white_check_mark:Succeeded View
docs/extensions/OnDeviceMarkup.md :white_check_mark:Succeeded View
docs/extensions/SurfaceDialTextboxHelper.md :white_check_mark:Succeeded View
docs/extensions/TextBoxMask.md :white_check_mark:Succeeded View
docs/extensions/TextBoxRegex.md :white_check_mark:Succeeded View
docs/extensions/TransformExtensions.md :white_check_mark:Succeeded View
docs/extensions/VisualEx.md :white_check_mark:Succeeded View

This comment lists only the first 25 files in the pull request. For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld32 commented 2 years ago

Docs Build status updates of commit 6e4625b:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/controls/Menu.md :white_check_mark:Succeeded View
docs/controls/OrbitView.md :white_check_mark:Succeeded View
docs/controls/RadialGauge.md :white_check_mark:Succeeded View
docs/controls/RadialProgressBar.md :white_check_mark:Succeeded View
docs/controls/RangeSelector.md :white_check_mark:Succeeded View
docs/controls/RemoteDevicePicker.md :white_check_mark:Succeeded View
docs/controls/RotatorTile.md :white_check_mark:Succeeded View
docs/controls/ScrollHeader.md :white_check_mark:Succeeded View
docs/controls/StaggeredPanel.md :white_check_mark:Succeeded View
docs/controls/TabView.md :white_check_mark:Succeeded View
docs/controls/TextToolbar.md :white_check_mark:Succeeded View
docs/controls/TileControl.md :white_check_mark:Succeeded View
docs/extensions/EnumValuesExtension.md :white_check_mark:Succeeded View
docs/extensions/Hyperlink.md :white_check_mark:Succeeded View
docs/extensions/LogicalTree.md :white_check_mark:Succeeded View
docs/extensions/MatrixExtensions.md :white_check_mark:Succeeded View
docs/extensions/MatrixHelperEx.md :white_check_mark:Succeeded View
docs/extensions/MouseCursor.md :white_check_mark:Succeeded View
docs/extensions/NullableBoolMarkup.md :white_check_mark:Succeeded View
docs/extensions/OnDeviceMarkup.md :white_check_mark:Succeeded View
docs/extensions/SurfaceDialTextboxHelper.md :white_check_mark:Succeeded View
docs/extensions/TextBoxMask.md :white_check_mark:Succeeded View
docs/extensions/TextBoxRegex.md :white_check_mark:Succeeded View
docs/extensions/TransformExtensions.md :white_check_mark:Succeeded View
docs/extensions/VisualEx.md :white_check_mark:Succeeded View

This comment lists only the first 25 files in the pull request. For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

kturetz commented 2 years ago

Global effort to fix broken links

@nmetulev @michael-hawker @Arlodotexe

The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only link fixes and does not change other content. I’d very much appreciate your timely review and feedback on the link changes I’ve suggested. Thanks!

michael-hawker commented 2 years ago

@Arlodotexe this is what I was calling out on the other PR #645 (which still has some as well).

It's because @kturetz didn't find the new location in our repo, so he commented it out instead.

This is a combination of a few things:

The main issue with trying to do this across the current docs is that we're basically planning on redoing our docs anyway for our next 8.0 release before year-end, so most of this is going to be temp effort as everything will change again.

kturetz commented 2 years ago

@Arlodotexe this is what I was calling out on the other PR #645 (which still has some as well).

It's because @kturetz didn't find the new location in our repo, so he commented it out instead.

This is a combination of a few things:

  • our repo org changed from windows-toolkit to CommunityToolkit (easy replacement)
  • uncaught changes from large 7.0 package refactor (a lot of these mean that anything with .Controls is probably now .Controls.<Subpackage>).
  • Animations refactor where somethings were removed/deprecated
  • Clean-ups to locations of some samples for animations/shadows

The main issue with trying to do this across the current docs is that we're basically planning on redoing our docs anyway for our next 8.0 release before year-end, so most of this is going to be temp effort as everything will change again.

Please let us know if you require any additional edits that will expedite review and merge of this PR. Thank you.

opbld32 commented 2 years ago

Docs Build status updates of commit e68fd1a:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/controls/Menu.md :white_check_mark:Succeeded View
docs/controls/OrbitView.md :white_check_mark:Succeeded View
docs/controls/RadialGauge.md :white_check_mark:Succeeded View
docs/controls/RadialProgressBar.md :white_check_mark:Succeeded View
docs/controls/RangeSelector.md :white_check_mark:Succeeded View
docs/controls/RemoteDevicePicker.md :white_check_mark:Succeeded View
docs/controls/RotatorTile.md :white_check_mark:Succeeded View
docs/controls/ScrollHeader.md :white_check_mark:Succeeded View
docs/controls/StaggeredPanel.md :white_check_mark:Succeeded View
docs/controls/TabView.md :white_check_mark:Succeeded View
docs/controls/TextToolbar.md :white_check_mark:Succeeded View
docs/controls/TileControl.md :white_check_mark:Succeeded View
docs/extensions/EnumValuesExtension.md :white_check_mark:Succeeded View
docs/extensions/Hyperlink.md :white_check_mark:Succeeded View
docs/extensions/LogicalTree.md :white_check_mark:Succeeded View
docs/extensions/MatrixExtensions.md :white_check_mark:Succeeded View
docs/extensions/MatrixHelperEx.md :white_check_mark:Succeeded View
docs/extensions/MouseCursor.md :white_check_mark:Succeeded View
docs/extensions/NullableBoolMarkup.md :white_check_mark:Succeeded View
docs/extensions/OnDeviceMarkup.md :white_check_mark:Succeeded View
docs/extensions/SurfaceDialTextboxHelper.md :white_check_mark:Succeeded View
docs/extensions/TextBoxMask.md :white_check_mark:Succeeded View
docs/extensions/TextBoxRegex.md :white_check_mark:Succeeded View
docs/extensions/TransformExtensions.md :white_check_mark:Succeeded View
docs/extensions/VisualEx.md :white_check_mark:Succeeded View

This comment lists only the first 25 files in the pull request. For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld32 commented 2 years ago

Docs Build status updates of commit 8df8eb2:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/controls/Menu.md :white_check_mark:Succeeded View
docs/controls/OrbitView.md :white_check_mark:Succeeded View
docs/controls/RadialGauge.md :white_check_mark:Succeeded View
docs/controls/RadialProgressBar.md :white_check_mark:Succeeded View
docs/controls/RangeSelector.md :white_check_mark:Succeeded View
docs/controls/RemoteDevicePicker.md :white_check_mark:Succeeded View
docs/controls/RotatorTile.md :white_check_mark:Succeeded View
docs/controls/ScrollHeader.md :white_check_mark:Succeeded View
docs/controls/StaggeredPanel.md :white_check_mark:Succeeded View
docs/controls/TabView.md :white_check_mark:Succeeded View
docs/controls/TextToolbar.md :white_check_mark:Succeeded View
docs/controls/TileControl.md :white_check_mark:Succeeded View
docs/extensions/EnumValuesExtension.md :white_check_mark:Succeeded View
docs/extensions/Hyperlink.md :white_check_mark:Succeeded View
docs/extensions/LogicalTree.md :white_check_mark:Succeeded View
docs/extensions/MatrixExtensions.md :white_check_mark:Succeeded View
docs/extensions/MatrixHelperEx.md :white_check_mark:Succeeded View
docs/extensions/MouseCursor.md :white_check_mark:Succeeded View
docs/extensions/NullableBoolMarkup.md :white_check_mark:Succeeded View
docs/extensions/OnDeviceMarkup.md :white_check_mark:Succeeded View
docs/extensions/SurfaceDialTextboxHelper.md :white_check_mark:Succeeded View
docs/extensions/TextBoxMask.md :white_check_mark:Succeeded View
docs/extensions/TextBoxRegex.md :white_check_mark:Succeeded View
docs/extensions/TransformExtensions.md :white_check_mark:Succeeded View
docs/extensions/VisualEx.md :white_check_mark:Succeeded View

This comment lists only the first 25 files in the pull request. For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

tfosmark commented 2 years ago

@michael-hawker I think this is ready to merge. If not, we can close this PR and I'll have someone else from my team finish the work. Thanks!

kturetz commented 2 years ago

Commenting out these broken links (while reviewing the replacements I've noted for others) and waiting for the repo team's new release to resolve them is an option. If you'd like to take that route, let's complete and merge these PRs.

In the meantime, let's look at an example that might help me enact additional fixes. Is there a working version of this link and if so, how would I determine it using the information Michael provided here?

PersonView source code

From: Michael Hawker MSFT (XAML Llama) @.> Sent: Thursday, June 9, 2022 5:05 PM To: MicrosoftDocs/WindowsCommunityToolkitDocs @.> Cc: Ken Turetzky (AQUENT LLC) @.>; Mention @.> Subject: Re: [MicrosoftDocs/WindowsCommunityToolkitDocs] [BrokenLinksH2] Fixed broken links (PR #646)

@Arlodotexehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FArlodotexe&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IXv20lA0soVI2ijRMqp57tNhnmCo4NK0VQMheRc4308%3D&reserved=0 this is what I was calling out on the other PR #645https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FWindowsCommunityToolkitDocs%2Fpull%2F645&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oawrVdh7QEzf0v76upn3Vrvne3rSudHAL7RLwAb8xms%3D&reserved=0 (which still has some as well).

It's because @kturetzhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkturetz&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nBOZwnW5WKu%2FObl2vcKQDTIphBrfMuFmU0bnI%2F2HtyY%3D&reserved=0 didn't find the new location in our repo, so he commented it out instead.

This is a combination of a few things:

The main issue with trying to do this across the current docs is that we're basically planning on redoing our docs anyway for our next 8.0 release before year-end, so most of this is going to be temp effort as everything will change again.

- Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FWindowsCommunityToolkitDocs%2Fpull%2F646%23issuecomment-1151623248&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Jn0aunxeULwZBeKThADNVAOc72Rj8fDykx9nYTsPJlI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAY4PHJET37GFNDTMLO5MQZLVOJL7DANCNFSM5YIFDBIQ&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MGxGTIyBvJC0lbfEO0s%2FU5T9AJb78xl5UEGgrxasszQ%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>