MicrosoftDocs / azure-aks-docs

Public sync with private repo azure-aks-docs-pr
Creative Commons Attribution 4.0 International
3 stars 60 forks source link

Fix inaccurate statement in keda-about.md #4

Closed JoeyC-Dev closed 3 months ago

JoeyC-Dev commented 3 months ago

Proposed change: Fix misleading statement in limitation section.

Related issues:

Supporting point: In the official FAQ, it explicitly says "external" metrics server. If we don't make it clear, this statement will make the misleading like in: https://github.com/Azure/AKS/issues/4436, and cause the user tried to delete the built-in metrics-server. image Src: https://keda.sh/docs/2.14/faq/#can-i-run-multiple-metric-servers-serving-external-metrics-in-the-same-cluster

To be clear, there are three types of metrics for Kubernetes. It is important to clarify what kind of metrics should be KEDA unique. image Src: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#support-for-metrics-apis

prmerger-automator[bot] commented 3 months ago

@JoeyC-Dev : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Jak-MS commented 3 months ago

@tomkerkhove Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

label:"aq-pr-triaged"

@MicrosoftDocs/public-repo-pr-review-team

tomkerkhove commented 3 months ago

sign-off