prmerger-automator[bot]
commented
1 month ago @reknai : Thanks for your contribution! The author(s) have been notified to review your proposed change.
Closed reknai closed 1 month ago
prmerger-automator[bot]
commented
1 month ago @reknai : Thanks for your contribution! The author(s) have been notified to review your proposed change.
learn-build-service-prod[bot]
commented
1 month ago Learn Build status updates of commit b11ed52:
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/aks/configure-azure-cni.md | :warning:Warning | Details |
Link 'https://learn.microsoft.com/en-us/powershell/azure/install-azps-macos?view=azps-12.3.0#update-the-azure-powershell-module' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.Link 'https://learn.microsoft.com/en-us/powershell/azure/install-azps-windows?view=azps-12.3.0&tabs=powershell&pivots=windows-psgallery#update-the-az-powershell-module' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.Link 'https://learn.microsoft.com/en-us/powershell/azure/install-azps-linux?view=azps-12.3.0#update-the-az-powershell-module' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.Absolute link 'https://learn.microsoft.com/en-us/powershell/azure/install-azps-macos?view=azps-12.3.0#update-the-azure-powershell-module' will be broken in isolated environments. Replace with a relative link.You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/powershell/azure/install-azps-macos?view=azps-12.3.0#update-the-azure-powershell-moduleAbsolute link 'https://learn.microsoft.com/en-us/powershell/azure/install-azps-windows?view=azps-12.3.0&tabs=powershell&pivots=windows-psgallery#update-the-az-powershell-module' will be broken in isolated environments. Replace with a relative link.You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/powershell/azure/install-azps-windows?view=azps-12.3.0&tabs=powershell&pivots=windows-psgallery#update-the-az-powershell-moduleAbsolute link 'https://learn.microsoft.com/en-us/powershell/azure/install-azps-linux?view=azps-12.3.0#update-the-az-powershell-module' will be broken in isolated environments. Replace with a relative link.You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/powershell/azure/install-azps-linux?view=azps-12.3.0#update-the-az-powershell-moduleFor more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
ShannonLeavitt
commented
1 month ago @reknai - Can you resolve the warnings listed above?
@asudbring - Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
@MicrosoftDocs/public-repo-pr-review-team
learn-build-service-prod[bot]
commented
1 month ago Learn Build status updates of commit 1a9b6b6:
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/aks/configure-azure-cni.md | :bulb:Suggestion | Details |
Absolute link 'https://learn.microsoft.com/powershell/azure/install-azps-macos' will be broken in isolated environments. Replace with a relative link.Absolute link 'https://learn.microsoft.com/powershell/azure/install-azps-windows' will be broken in isolated environments. Replace with a relative link.Absolute link 'https://learn.microsoft.com/powershell/azure/install-azps-linux' will be broken in isolated environments. Replace with a relative link.For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
learn-build-service-prod[bot]
commented
1 month ago Learn Build status updates of commit 19c1e80:
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/aks/configure-azure-cni.md | :white_check_mark:Succeeded |
For more details, please refer to the build report.
For any questions, please:
reknai
commented
1 month ago @ShannonLeavitt Any update on the merging of this PR? Thx!
asudbring
commented
1 month ago @reknai Please address the changes and feedback and then we can sign off for merge. Thanks!
reknai
commented
1 month ago @asudbring : the suggestions have been incorporated. Please check. Thank you!
asudbring
commented
1 month ago @asudbring : the suggestions have been incorporated. Please check. Thank you!
@reknai I'm not seeing the changes or a new build happening. You can commit the suggested changes in the comments and it will automatically commit them and rebuild the PR. The last commit I'm seeing on this PR was 10/8. If you made the changes locally you have to push them up to Github for this PR.
reknai
commented
1 month ago @asudbring : I see it was not committed and I somehow missed it. Sorry about that. Now it should be in.
learn-build-service-prod[bot]
commented
1 month ago Learn Build status updates of commit 4f07742:
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/aks/configure-azure-cni.md | :white_check_mark:Succeeded |
For more details, please refer to the build report.
For any questions, please:
asudbring
commented
1 month ago
PR for https://supportability.visualstudio.com/AzureContainers/_workitems/edit/80451