Closed JoeyC-Dev closed 3 months ago
@JoeyC-Dev : Thanks for your contribution! The author(s) have been notified to review your proposed change.
@asudbring Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off
comment is the best way to signal that the PR is ready for the review team to merge.
@MicrosoftDocs/public-repo-pr-review-team
@JoeyC-Dev, thank you for your contribution to the AKS documentation!
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @asudbring
I created a new PR so we can get these updates merged ASAP (link: https://github.com/MicrosoftDocs/azure-aks-docs-pr/pull/65). Closing this one out. Thanks again!
@schaffererin in the past, PR team will merge them shortly once you approved the PR even you cannot execute the sign-off
. You can leave it be or just mention member of PR team and they will check.
BYW no public user can see azure-aks-docs-pr
.
Proposed change: Fix wrong service name.
Supporting point: In the line 389, the service name literally is
store-front
: https://github.com/MicrosoftDocs/azure-aks-docs/blob/a75aabed22a97f8ef63ae6bb23b4bba92d1d7319/articles/aks/limit-egress-traffic.md?plain=1#L389Also in Line 395, same: https://github.com/MicrosoftDocs/azure-aks-docs/blob/a75aabed22a97f8ef63ae6bb23b4bba92d1d7319/articles/aks/limit-egress-traffic.md?plain=1#L395
But the sentence pointing to this service is wrong: https://github.com/MicrosoftDocs/azure-aks-docs/blob/a75aabed22a97f8ef63ae6bb23b4bba92d1d7319/articles/aks/limit-egress-traffic.md?plain=1#L392