search

MicrosoftDocs / azure-devops-docs

This repo is the home of the official Azure DevOps documentation for Microsoft. GitHub Issues filed in this repository should be for problems with the documentation.
https://docs.microsoft.com/azure/devops/
Creative Commons Attribution 4.0 International
830 stars 2.45k forks source link

Edited private-powershell-library.md #3404

Closed istvan2015 closed 5 years ago

istvan2015 commented 5 years ago

Edited private-powershell-library.md to include example for .pkgs.visualstudio.com (PS code example)

PRMerger18 commented 5 years ago

@istvan2015 : Thanks for your contribution! The author, @elbatk, has been notified to review your proposed change.

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

PRMerger20 commented 5 years ago

@istvan2015 : Thanks for your contribution! The author, @elbatk, has been notified to review your proposed change.

elbatk commented 5 years ago

Reviewing this soon! Thanks @istvan2015

istvan2015 commented 5 years ago

Great, thank you. Let me know what you think

PRMerger13 commented 5 years ago

@istvan2015 : Thanks for your contribution! The author, @elbatk, has been notified to review your proposed change.

nschonni commented 5 years ago

Outside of what you changed, but I think https://github.com/MicrosoftDocs/vsts-docs/blame/02752afb793a1583b7464ac4ce9c79211e2a90d4/docs/artifacts/tutorials/private-powershell-library.md#L203 needs to be switched, since it is also referencing the v3 endpoint

istvan2015 commented 5 years ago

@nschonni Thank you for the input. As far as I am aware and as far as I have tested, that is not true, because I was able to successfully connect NuGet using the v3 endpoint - which is actually whichever endpoint the developers have to use for their current Azure DevOps setup.

However, your comment did open my eyes to the fact that the line you mentioned is correct, but I need to add another line below to include the example URL for the old visualstudio.com versions as well, exactly as @alexmullans pointed out.

I hope that makes sense

nschonni commented 5 years ago

PowerShellGallery doesn't support NuGet v3, only v2. That is mentioned in other parts of the article

nschonni commented 5 years ago

I might be mixing up how this particular v3 endpoint is being used. Maybe publishing to v3 is fine, as long as the pull is done from v2

istvan2015 commented 5 years ago

I might be mixing up how this particular v3 endpoint is being used. Maybe publishing to v3 is fine, as long as the pull is done from v2

Well, you are right in the sense that PowerShellGallery doesn't support Nuget v3. However, that particular line (line # 203) only adds a feed to Nuget locally on the computer from which it was called, and names it PowershellModules. That's why it works with v3, because it's simply adding a feed, you give it a name, of course it works.

Sorry if I am mistaking, I'm not trying to enforce my point of view here, just trying to explain my limited experience with these bits.

PRMerger18 commented 5 years ago

@istvan2015 : Thanks for your contribution! The author, @elbatk, has been notified to review your proposed change.

infin8x commented 5 years ago

@istvan2015 thanks for the contribution, we appreciate it!