search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.26k stars 21.43k forks source link

The scenario may be better if it was closer to a real world example #109849

Closed Expecho closed 1 year ago

Expecho commented 1 year ago

So, given the scenario as described in the docs one thing is not quit clear to me. It seems it rate limits based on the total number of requests. In a large number of real world scenarios this would probably be based on the source IP.

In the example in this doc, the rate limit is applied to the /promo endpoint. Does it mean that if there are over a thousand requests in the specified period originating from several IPs all incoming traffic will be rate limited or is it applied per source IP? e.g. the one IP that generates over 1000 requests is rate limited, the other IP that generates a new request is allowed through?

If the total number of requests is the only deciding factor, how could this example be extended so that the rate limit is applied based on the number of requests per source IP to the promo endpoint. I think it will make this example more real world with the added benefit that it can explain how multiple conditions can be set up and controlled.

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ChaitanyaNaykodi-MSFT commented 1 year ago

@Expecho Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

vhorne commented 1 year ago

@Expecho Perhaps there is some confusion with the phrase from a particular socket IP address in the article. The word from implies it is a source IP address that is being discussed. But perhaps this is too subtle. I'll adjust the phrasing in the article to explicitly state source IP address.

For example, the lead paragraph now reads:

The Azure Web Application Firewall (WAF) rate limit rule for Azure Front Door controls the number of requests allowed from a particular source IP address to the application during a rate limit duration.

please-close