MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.14k stars 21.23k forks source link

Managed identity section of NFM page is incomplete #111431

Open tomprice-msft opened 1 year ago

tomprice-msft commented 1 year ago

The steps in the Managed identity section are incomplete, they should be as follows:

  1. Create a custom role with permissions for Microsoft.HybridNetwork/devices/join/action, unless one already exists. The documentation for this is here: https://learn.microsoft.com/en-us/azure/role-based-access-control/custom-roles-portal, but we should be specific about which sections of that article apply because in step 1 they already know they need Microsoft.HybridNetwork/devices/join/action, and the "Clone a role" method isn't appropriate.
  2. Create a user-assigned managed identity, unless one already exists. https://learn.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/how-manage-user-assigned-managed-identities?pivots=identity-mi-methods-azp#create-a-user-assigned-managed-identity
  3. Assign the user-assigned managed identity the custom role from above at the scope of the Azure Stack Edge, or the Resource Group or Subscription containing the Azure Stack Edge. https://learn.microsoft.com/en-us/azure/role-based-access-control/role-assignments-portal-managed-identity#user-assigned-managed-identity
  4. Provide this managed identity when creating a partner’s managed application in the Azure portal. There is no additional documentation for this; the existing link is wrong.

Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

YashikaTyagii commented 1 year ago

@tomprice-msft Thanks for your feedback! We will investigate and update as appropriate.

tomprice-msft commented 1 year ago

It also turns out that Microsoft.HybridNetwork/devices/join/action isn't a valid action anymore, so please update this to the correct required permission.