MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.28k stars 21.47k forks source link

Documentation change on supported data sources on SQL connector. #120459

Closed v-qalhanouti closed 7 months ago

v-qalhanouti commented 8 months ago

We are looking to add more clarity to the following document : https://learn.microsoft.com/en-us/azure/data-factory/connector-sql-server?tabs=data-factory#supported-capabilities

on this part it mentions the supported data sources on this connector :

Specifically, this SQL Server connector supports:

SQL Server version 2005 and above. Copying data by using SQL or Windows authentication. As a source, retrieving data by using a SQL query or a stored procedure. You can also choose to parallel copy from SQL Server source, see the Parallel copy from SQL database section for details. As a sink, automatically creating destination table if not exists based on the source schema; appending data to a table or invoking a stored procedure with custom logic during copy. [SQL Server Express LocalDB] is not supported.

the ask :

we should add a very important note that the data source should have the capability to support NVARCAR data type as it might affect the data encoding when non-universal coding is being applied on the data.


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

SaibabaBalapur-MSFT commented 8 months ago

@v-qalhanouti Thanks for your feedback! We will investigate and update as appropriate.

Naveenommi-MSFT commented 8 months ago

@v-qalhanouti Thank you for bringing this to our attention. I've delegated this to content author @jianleishen, who will review it and offer their insightful opinions.

Naveenommi-MSFT commented 8 months ago

@jianleishen Could you please review add comments on this, update as appropriate.

jonburchel commented 7 months ago

Hi @v-qalhanouti, and thanks for your dedication to helping us improve the docs! Regarding the note you requested we add to the supported data sources, that implies that at least one of the SQL versions >= SQL 2005 does not support NVARCHAR, since those are the sources indicated that we support. I believe all versions of SQL from SQL 2005 onward do already support that data type though, in which case such a note would be redundant to what was already said. Did I misunderstand the ask though, or am I mistaken about the SQL versions? I want to be sure before I make any change.

Jon

v-qalhanouti commented 7 months ago

Hi Jon,

Thanks for replying. You understood it correctly. The only problem is that there is several products that are built on SQL engine but they don't support NVARCAR type which leads to some hardship we have to deal with with customers. So we would appreciate adding this note so it would be clear to everyone when we run into functionality issues because of the absence of NVARCAR support.

thanks

Qusai Alhanouti Support Engineer | Azure Data Movement | Customer Service and Support @.**@.> Working hours: Monday - Friday | 09:30 - 18:30 (UTC + 3)

@.***

If you have any feedback of your Support Experience, please feel free to contact my manager - Khalid Abu Qtaish at: @.**@.>

From: Jon Burchel @.> Sent: Thursday, March 21, 2024 10:30 PM To: MicrosoftDocs/azure-docs @.> Cc: Qusai Al-Hanouti (Estarta Solutions) @.>; Mention @.> Subject: Re: [MicrosoftDocs/azure-docs] Documentation change on supported data sources on SQL connector. (Issue #120459)

Hi @v-qalhanoutihttps://github.com/v-qalhanouti, and thanks for your dedication to helping us improve the docs! Regarding the note you requested we add to the supported data sources, that implies that at least one of the SQL versions >= SQL 2005 does not support NVARCHAR, since those are the sources indicated that we support. I believe all versions of SQL from SQL 2005 onward do already support that data type though, in which case such a note would be redundant to what was already said. Did I misunderstand the ask though, or am I mistaken about the SQL versions? I want to be sure before I make any change.

Jon

- Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/120459#issuecomment-2013459001, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGWICQX56SHMB3OZIQFZJRLYZMYMPAVCNFSM6AAAAABEG2NUG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTGQ2TSMBQGE. You are receiving this because you were mentioned.Message ID: @.***>