MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.31k stars 21.48k forks source link

No runtime/SDK installation instructions on the page. #121423

Closed darkoa-msft closed 7 months ago

darkoa-msft commented 7 months ago

It is not clear that SDK requires runtime to be installed.

Also, until you run the runtime installer, it is not obvious that it has to be run from a command line with /accepteula flag.

I could have sworn that runtime used to be bundled with SDK. Being that a) SDK requires runtime and b) versions MUST match, what is the reason to provide SDK without runtime?


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

TPavanBalaji commented 7 months ago

@darkoa-msft Thanks for your feedback! We will investigate and update as appropriate.

tomvcassidy commented 7 months ago

Hi, @darkoa-msft ! I downloaded it myself and see what you mean. I'll update the documentation to make it clear that the runtime .exe has to be run from a command line with -AcceptEULA specified.

I'm not entirely sure why the runtime isn't packaged with the runtime. I'll reach out to the product team and ask/make the suggestion. That's probably a better question to raise on the product github itself: https://github.com/Microsoft/service-fabric

If I hear back before I make your suggested changes and close this issue, I'll post the response here, but I'm going to focus on the documentation issue specifically.

Thanks! I'll update when changes are pushed.

tomvcassidy commented 7 months ago

Changes are merged as of this PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/271594 . They will go live later today.

If you have any other feedback, feel free to comment here again or open a new issue. Until then, thanks for the feedback and #please-close