MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.28k stars 21.47k forks source link

Private Link and DNS integration at scale - Incorrect Code #121583

Open chris-dnv opened 7 months ago

chris-dnv commented 7 months ago

The relevant Azure service or technology. Cloud Adoption Framework for Azure

A link to the published documentation article that you have feedback about. https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/private-link-and-dns-integration-at-scale#policy-definitions

Clear, specific feedback that the author can act on. In this section code is provided that should block the storage account creation can be if the "Integrate with PrivateDNSZone" option is selected. This code fails to work as the creation of a storage account is parameterised therefore the values don't exist. This is an important feature to have for Private DNS integration at scale so it would be useful to see a working example of this.

TPavanBalaji commented 7 months ago

@chris-dnv Thank you for bringing this to our attention. I've delegated this to content author, who will review it and offer their insightful opinions.