MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
9.98k stars 20.95k forks source link

Fix wrong command in cluster-autoscaler.md #121999

Open JoeyC-Dev opened 1 week ago

JoeyC-Dev commented 1 week ago

Proposed changes: Fix wrong command which is not executable. Result: Environment: Cloud Shell

az aks update -n ${aks} -g ${rG} --cluster-autoscaler-profile scan-interval=30s,scale-down-delay-after-add=0m,scale-down-delay-after-failure=1m,scale-down-unneeded-time=3m,scale-down-unready-time=3m,max-graceful-termination-sec=30,skip-nodes-with-local-storage=false,max-empty-bulk-delete=1000,max-total-unready-percentage=100,ok-total-unready-count=1000,max-node-provision-time=15m
{
  "aadProfile": null,
  "addonProfiles": {
    "azurepolicy": {
      "config": null,
      "enabled": true,
      ...(no need to expand)

Basis: The current command is not executable due to:

  1. There is a space inside:
    joey [ ~ ]$ az aks update -n ${aks} -g ${rG} --cluster-autoscaler-profile scan-interval=30s, scale-down-delay-after-add=0s,scale-down-delay-after-failure=30s,scale-down-unneeded-time=3m,scale-down-unready-time=3m,max-graceful-termination-sec=30,skip-nodes-with-local-storage=false,max-empty-bulk-delete=1000,max-total-unready-percentage=100,ok-total-unready-count=1000,max-node-provision-time=15m
    Empty key specified for cluster-autoscaler-profile
  2. The value's unit (e.g. h, m, s) for the the parameter is wrong:
    joey [ ~ ]$ az aks update -n ${aks} -g ${rG} --cluster-autoscaler-profile scan-interval=30s,scale-down-delay-after-add=0s,scale-down-delay-after-failure=30s,scale-down-unneeded-time=3m,scale-down-unready-time=3m,max-graceful-termination-sec=30,skip-nodes-with-local-storage=false,max-empty-bulk-delete=1000,max-total-unready-percentage=100,ok-total-unready-count=1000,max-node-provision-time=15m
    (InvalidParameter) Invalid value specified for the cluster-autoscaler parameter 'scale-down-delay-after-add'. Please refer to https://aka.ms/cluster-autoscaler for more details.
    Code: InvalidParameter
    Message: Invalid value specified for the cluster-autoscaler parameter 'scale-down-delay-after-add'. Please refer to https://aka.ms/cluster-autoscaler for more details.
prmerger-automator[bot] commented 1 week ago

@JoeyC-Dev : Thanks for your contribution! The author(s) have been notified to review your proposed change.

learn-build-service-prod[bot] commented 1 week ago

Learn Build status updates of commit 4eec4ae:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/aks/cluster-autoscaler.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Court72 commented 1 week ago

@schaffererin

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

label:"aq-pr-triaged"

@MicrosoftDocs/public-repo-pr-review-team