MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure

https://docs.microsoft.com/azure

Creative Commons Attribution 4.0 International

10k stars 21k forks source link

Update action-groups.md #122061

Closed azarboon closed 1 week ago

azarboon commented 2 weeks ago

The following fact hasn't been mentioned anywhere in the doc:

"Action groups are created for each unique set of users that will be notified. For example, if User1, User2 and User3 have to be notified for two alert rules, you need to create only one action group."

prmerger-automator[bot] commented 2 weeks ago

@azarboon : Thanks for your contribution! The author(s) have been notified to review your proposed change.

learn-build-service-prod[bot] commented 2 weeks ago

Learn Build status updates of commit 3e5290a:

:white_check_mark: Validation status: passed

File	Status	Preview URL	Details
articles/azure-monitor/alerts/action-groups.md	:white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

Court72 commented 2 weeks ago

@AbbyMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

label:"aq-pr-triaged"

@MicrosoftDocs/public-repo-pr-review-team

AbbyMSFT commented 2 weeks ago

Hi @azarboon , Thanks for opening this PR. I am trying to understand the change you are trying to make. What happens if the same users have to be notified, but the action is different? I am concerned that your change implies that as long as the intended recipients are the same, even if the actions are different, you can still create only one action group. Happy to discuss over email or Teams, and to include @jacegummersall for his input. Thanks, Abby

azarboon commented 2 weeks ago

@AbbyMSFT how about this? Please feel free to edit it:

"So long as actions are the same, Action Groups are created for each unique set of users that will be notified. For example, if User1, User2 and User3 have to be notified e.g. by email for two alert rules, you need to create only one action group."

AbbyMSFT commented 2 weeks ago

@azarboon , much better! I've edited a little bit:

"Action Groups are defined by the unique set of actions and the users to be notified. For example, if you want to notify User1, User2 and User3 by email for two different alert rules, you only need to create one action group which you can apply to both alert rules."

How does that sound?

Abby

azarboon commented 2 weeks ago

@AbbyMSFT its great. Please edit and merge it.

AbbyMSFT commented 1 week ago

Hi @azarboon It is your branch, so you need to make the change, and then I can approve. Thanks, Abby

azarboon commented 1 week ago

@AbbyMSFT modified it and committed changes. Kindly please approve it.

learn-build-service-prod[bot] commented 1 week ago

Learn Build status updates of commit 597667c:

:white_check_mark: Validation status: passed

File	Status	Preview URL	Details
articles/azure-monitor/alerts/action-groups.md	:white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

AbbyMSFT commented 1 week ago