MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure

https://docs.microsoft.com/azure

Creative Commons Attribution 4.0 International

10k stars 21k forks source link

fix obvious mistake #122201

Closed rafalfitt closed 1 week ago

learn-build-service-prod[bot] commented 2 weeks ago

Learn Build status updates of commit acac09b:

:white_check_mark: Validation status: passed

File	Status	Preview URL	Details
articles/defender-for-cloud/how-to-transition-to-built-in.yml	:white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

prmerger-automator[bot] commented 2 weeks ago

PRMerger Results

Issue	Description
Yaml File(s)	This PR includes changes to .yml file(s) owned by another author.

Court72 commented 2 weeks ago

@dcurwin

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

label:"aq-pr-triaged"

@MicrosoftDocs/public-repo-pr-review-team

dcurwin commented 2 weeks ago

sign-off

prmerger-automator[bot] commented 2 weeks ago

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

dcurwin commented 2 weeks ago

sign-off

prmerger-automator[bot] commented 2 weeks ago

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

ElazarK commented 1 week ago

sign-off

prmerger-automator[bot] commented 1 week ago

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

dcurwin commented 1 week ago

sign-off

prmerger-automator[bot] commented 1 week ago

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

dcurwin commented 1 week ago

@MicrosoftDocs/public-repo-pr-review-team Do you know why I'm not able to sign off on this PR? I am the author of the document.

dcurwin commented 1 week ago

please-close

dcurwin commented 1 week ago

Closing this PR, opening again in the private repo.

Court72 commented 1 week ago

@MicrosoftDocs/public-repo-pr-review-team Do you know why I'm not able to sign off on this PR? I am the author of the document.

Hi @dcurwin,

PRMerger only recognizes author metadata that's in the article itself. Because the author metadata is defined globally in the docfx.json in this case, PRMerger thinks the author is blank, so it doesn't accept your signoff.

PR reviewers do monitor approvals and signoffs, so the team can merge even when PRMerger isn't recognizing a signoff from the author.

Thanks!