search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10k stars 21k forks source link

[Container Instances] The example of YAML for deployment is incorrect. #122214

Closed mag-chang closed 1 week ago

mag-chang commented 2 weeks ago

Hello team,

I want to let you know the document has incorrect section. This document is showing an example of YAML for GitHub Actions to deploy to ACR. However, the yaml is incorrect. I am going to explain about it at following.

  1. The step of 'Build and push image' has incorrect outer brackets for registry. $({ secrets.REGISTRY_LOGIN_SERVER })
  2. The username and password have missing secrets. These should be pointed as REGISTRY_USERNAME and REGISTRY_PASSWORD.

I would happy to check it once.

Thanks,

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

PesalaPavan commented 2 weeks ago

@mag-chang Thanks for your feedback! We will investigate and update as appropriate.

tomvcassidy commented 1 week ago

Hi @mag-chang! Thank you for catching these issues. Below are the changes I plan to make:

Current:

Proposed:

Please let me know if these corrections address the issues you've identified or if I've missed anything. Thank you!

mag-chang commented 1 week ago

Hello @tomvcassidy , Thank you for your fixing the issue! I think the changes are appropriate. I appreciate your quick action.

PesalaPavan commented 1 week ago

@mag-chang We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

tomvcassidy commented 1 week ago

Thank you, all. The changes are merged as of https://github.com/MicrosoftDocs/azure-docs-pr/pull/274510 and will be published later today.