MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10k stars 21k forks source link

Fix code in enable-dynamic-configuration-dotnet-core-push-refresh.md #122221

Closed artemious7 closed 1 week ago

artemious7 commented 2 weeks ago
prmerger-automator[bot] commented 2 weeks ago

@artemious7 : Thanks for your contribution! The author(s) have been notified to review your proposed change. @MBSolomon

learn-build-service-prod[bot] commented 2 weeks ago

Learn Build status updates of commit 6809e05:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/azure-app-configuration/enable-dynamic-configuration-dotnet-core-push-refresh.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

learn-build-service-prod[bot] commented 2 weeks ago

Learn Build status updates of commit 0364a6a:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/azure-app-configuration/enable-dynamic-configuration-dotnet-core-push-refresh.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Court72 commented 1 week ago

@zhenlan

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

label:"aq-pr-triaged"

@MicrosoftDocs/public-repo-pr-review-team

zhenlan commented 1 week ago

The change looks reasonable to me.

@amerjusupovic can you please help validate the code works as expected?

amerjusupovic commented 1 week ago

@zhenlan confirmed the example doesn't work currently, and with the changes it now works as expected where key-value updates are logged to the console.

zhenlan commented 1 week ago

Thank you for the verification, @amerjusupovic.

sign-off

prmerger-automator[bot] commented 1 week ago

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @MBSolomon