search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.01k stars 21k forks source link

Incorrect compuation of search units based on replica and partition #122263

Closed rudraTransact2 closed 1 week ago

rudraTransact2 commented 1 week ago

This page contains search unit (SU) calculation as # of replicas times # of partitions. While this may have been true in the past, it is no longer going forward with shards. Please correct the documentation or provide proper explanation. See https://learn.microsoft.com/en-us/azure/search/search-capacity-planning for more information on the shards.

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

HeidiSteen commented 1 week ago

@mrcarter8 Can you comment on this issue? Has the SU calculation changed?

mrcarter8 commented 1 week ago

There have been no changes to how search unit counts are calculated. It's still partitions x replicas. We have no plans to bring shard count into any billing related calculations. It is strictly an internal implementation detail of the service. Please help us understand where you got the impression that this would be changing. Thanks.

rudraTransact2 commented 1 week ago

This part of this new doc https://learn.microsoft.com/en-us/azure/search/search-limits-quotas-capacity#subscription-limits shows the 36 Units for S1 resource. The different portion of the same doc (https://learn.microsoft.com/en-us/azure/search/search-limits-quotas-capacity#subscription-limits) shows the replicas as 12 and partitions as 12 for the same resource. If the SU calculation is replicas * partitions, then SU should have been 144 and not 36. This confused me. Can you please elaborate how we are supposed to interpret this information?

HeidiSteen commented 1 week ago

There's an SU combination chart in the search-limits-quotas-capacity doc that shows legitimate combinations. I grabbed a screenshot so you need to look at this post in preview mode to see it, but 12x12 isn't allowed:

image
rudraTransact2 commented 1 week ago

Can you please post the link to the above doc?

HeidiSteen commented 1 week ago

Sorry about that, I referenced the wrong file name. This is the file with the table: https://learn.microsoft.com/en-us/azure/search/search-capacity-planning#partition-and-replica-combinations

rudraTransact2 commented 1 week ago

I would say that the documentation should still be updated that the calculation holds true only up to 36 SUs by referencing the above page.

HeidiSteen commented 1 week ago

I can do that -- thanks for suggesting it and apologies for the confusion.

HeidiSteen commented 1 week ago

@rudraTransact2, the doc update is live. I added a link. I also relocated the sharding section to a search anomalies article and cleaned up the doc overall. "How sharding works" is somewhat tangential to capacity management or planning and it shouldn't have been in this doc. I'm closing this issue because I think it's been addressed, but feel free to reopen or reply back on this thread. I get the comments even if the issue is closed.

please-close