MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure

https://docs.microsoft.com/azure

Creative Commons Attribution 4.0 International

10.25k stars 21.42k forks source link

fix code highlighting in concepts-models.md #124653

Closed BartekSTRX closed 4 days ago

BartekSTRX commented 6 days ago

fix code highlighting - currently highlighted lines of code are out of sync with linked files

pics below show how it looks before the changes Capture3 Capture2 Capture

prmerger-automator[bot] commented 6 days ago

@BartekSTRX : Thanks for your contribution! The author(s) have been notified to review your proposed change.

BartekSTRX commented 6 days ago

Relevant file: https://github.com/Azure-Samples/azure-digital-twins-getting-started/blob/main/models/advanced-home-example/IRoom.json

learn-build-service-prod[bot] commented 6 days ago

Learn Build status updates of commit f6fab35:

:white_check_mark: Validation status: passed

File	Status	Preview URL	Details
articles/digital-twins/concepts-models.md	:white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

Jak-MS commented 6 days ago

@baanders Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

label:"aq-pr-triaged"

@MicrosoftDocs/public-repo-pr-review-team

BartekSTRX commented 4 days ago

@baanders all looks good, I think it can be merged

baanders commented 4 days ago

Hi @BartekSTRX, thank you for reviewing my comments! In order to merge this pull request, you'll need to implement the requsted changes by adding a new commit. Alternatively, I can make the updates myself in a separate PR and close this one if that is easier for you. :)

BartekSTRX commented 4 days ago

fixed according to suggestions

learn-build-service-prod[bot] commented 4 days ago

Learn Build status updates of commit 9fe3989:

:white_check_mark: Validation status: passed

File	Status	Preview URL	Details
articles/digital-twins/concepts-models.md	:white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

baanders commented 4 days ago

@BartekSTRX Thank you for making the edits! This PR is ready for merge.

baanders commented 4 days ago