MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure

https://docs.microsoft.com/azure

Creative Commons Attribution 4.0 International

10.31k stars 21.48k forks source link

Keep dots in category names to override using app settings #124857

Closed FHajHusein closed 6 days ago

FHajHusein commented 1 week ago

If the dots in the category name are replaced with double underscores, we wouldn't end up with the desired category name.

For example, the category name from the following app setting would be Host:Aggregator, when Host.Aggregator is what we want:

AzureFunctionsJobHost__logging__logLevel__Host__Aggregator

The app setting should be:

AzureFunctionsJobHost__logging__logLevel__Host.Aggregator

prmerger-automator[bot] commented 1 week ago

@FHajHusein : Thanks for your contribution! The author(s) have been notified to review your proposed change.

learn-build-service-prod[bot] commented 1 week ago

Learn Build status updates of commit 96a7edc:

:white_check_mark: Validation status: passed

File	Status	Preview URL	Details
articles/azure-functions/configure-monitoring.md	:white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

Jak-MS commented 1 week ago

@ggailey777 Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

label:"aq-pr-triaged"

@MicrosoftDocs/public-repo-pr-review-team

ggailey777 commented 1 week ago

Thanks for taking the time to fix the previous (incorrect) update for the setting name values. The content repo is currently locked for Microsoft Ignite 2024, but your updates should merge the week of 11/18.

sign-off

Court72 commented 1 week ago

This PR is ready for merge. Due to the upcoming Ignite conference, all merging and publishing is on hold until the morning of the keynote address.

The PR review team will resume merging on the morning of the keynote address for the regularly scheduled daily publish cycles. You don't need to take further action on this PR; we'll merge it on the day of the keynote address.

Don't add more commits to this reviewed PR. If you need to make additional changes to these files, email techdocprs for guidance about how to proceed.

label:"missed-content-complete","event-triaged-to-10AM"