search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.2k stars 21.35k forks source link

Error in code sample in Add a probe to an existing application gateway? #48555

Closed janus-christensen closed 4 years ago

janus-christensen commented 4 years ago

Hello in the code sample provided in the section Add a probe to an existing application gateway (https://docs.microsoft.com/en-us/azure/application-gateway/application-gateway-create-probe-ps#add-a-probe-to-an-existing-application-gateway) the third line uses the variable $probe to add the code to the backend HTTP settings. No where in the code sample is the variable being set.

What is the correct form of Set-AzApplicationGatewayBackendHttpSettings to use in this case?

Thank you, Janus

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

SubhashVasarapu-MSFT commented 4 years ago

@janus-christensen , Thanks for your feedback. We are looking into this query and will update you as soon as possible.

SubhashVasarapu-MSFT commented 4 years ago

@janus-christensen , I would request you to go through the doc where it was listed under PowerShell block of code while creating Application Gateway. Screenshot for your reference, image We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

janus-christensen commented 4 years ago

Hello,

I am not satisfied with your explanation.

Why does the call to Set-AzApplicationGatewayBackendHttpSettings in code section as shown below use the $probe variable when in the line just before, it creates the probe configuration using Add-AzApplicationGatewayProbeConfig?

Load the application gateway resource into a PowerShell variable by using Get-AzApplicationGateway.

$getgw = Get-AzApplicationGateway -Name appgwtest -ResourceGroupName appgw-rg

Create the probe object that will check health at http://contoso.com/path/path.htm

$getgw = Add-AzApplicationGatewayProbeConfig -ApplicationGateway $getgw -Name probe01 -Protocol Http -HostName 'contoso.com' -Path '/path/custompath.htm' -Interval 30 -Timeout 120 -UnhealthyThreshold 8

Set the backend HTTP settings to use the new probe

$getgw = Set-AzApplicationGatewayBackendHttpSettings -ApplicationGateway $getgw -Name $getgw.BackendHttpSettingsCollection.name -Port 80 -Protocol Http -CookieBasedAffinity Disabled -Probe $probe -RequestTimeout 120

Save the application gateway with the configuration changes

Set-AzApplicationGateway -ApplicationGateway $getgw

It does not follow that the $probe variable is present in the code example in the section Add a probe to an existing application gateway and the code example in your screenshot come from the section Create an application gateway. These are two distinct scenarios and I would not expect a code example for one scenario to rely on the code example from a completely different scenario. Even if that were the case, why call Add-AzApplicationGatewayProbeConfig if the probe configuration is already present in the $probe variable as you seem to suggest?

Best regards, Janus Christensen, CGI

From: suvasara notifications@github.com Sent: 21. februar 2020 09:52 To: MicrosoftDocs/azure-docs azure-docs@noreply.github.com Cc: Christensen, Janus janus.christensen@cgi.com; Mention mention@noreply.github.com Subject: Re: [MicrosoftDocs/azure-docs] Error in code sample in Add a probe to an existing application gateway? (#48555)

@janus-christensenhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_janus-2Dchristensen&d=DwMCaQ&c=H50I6Bh8SW87d_bXfZP_8g&r=KMXJaIYDMakdfCvEJMhCZtNlRlSAHAYcVi06prpFJFI&m=_jLNnHdl_E9gnLmS26iH_z5OA-2IjIYN8QibWZsrU4A&s=9-4OnsgfFUPW9cs9svtb61p3FclDBfvuaJJdhXEeQxI&e= , I would request you to go through the doc where it was listed under PowerShell block of code while creating Application Gateway. Screenshot for your reference, [image]https://urldefense.proofpoint.com/v2/url?u=https-3A__user-2Dimages.githubusercontent.com_44890829_75023372-2Db7f41400-2D54bd-2D11ea-2D8e3e-2D90f4467d3245.png&d=DwMCaQ&c=H50I6Bh8SW87d_bXfZP_8g&r=KMXJaIYDMakdfCvEJMhCZtNlRlSAHAYcVi06prpFJFI&m=_jLNnHdl_E9gnLmS26iH_z5OA-2IjIYN8QibWZsrU4A&s=BG5JaETFC1DX7L3fALN9L1P1try1cL-wsGjaxVX8f3Q&e= We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_azure-2Ddocs_issues_48555-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAEGF62M46AK3DENHKFNRDL3RD6P4FA5CNFSM4KYM4FD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMSEVDQ-23issuecomment-2D589580942&d=DwMCaQ&c=H50I6Bh8SW87d_bXfZP_8g&r=KMXJaIYDMakdfCvEJMhCZtNlRlSAHAYcVi06prpFJFI&m=_jLNnHdl_E9gnLmS26iH_z5OA-2IjIYN8QibWZsrU4A&s=6If4fuZzBWV8P7_5IWNQ5qe33uhZVA7RHRB3EHyKz7A&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AEGF62JZN4ENLQYMW3FP6EDRD6P4FANCNFSM4KYM4FDQ&d=DwMCaQ&c=H50I6Bh8SW87d_bXfZP_8g&r=KMXJaIYDMakdfCvEJMhCZtNlRlSAHAYcVi06prpFJFI&m=_jLNnHdl_E9gnLmS26iH_z5OA-2IjIYN8QibWZsrU4A&s=9LSjOUy_06xVvSAFexOrnfKWmnY29BQ1hGiKfsQGhI0&e=.