MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.21k stars 21.36k forks source link

Provide clarification that AKSEndpoint option *requires* a version (different from the endpoint name) in the deployment config #53364

Closed djpugh closed 4 years ago

djpugh commented 4 years ago

Can you provide a clarification in the docs that the AKSEndpoint deployment config needs a version_name that is different from the endpoint name, otherwise endpoint update calls etc. will fail (e.g. can't update the endpoint to enable/disable app insights, add auth) if a version name is not provided in the deployment config (I'd suggest that this is a bug in the code, but I'm not sure where to raise that)


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

RohitMungi-MSFT commented 4 years ago

@djpugh Thanks for the feedback. We are investigating the issue and will update you shortly.

RohitMungi-MSFT commented 4 years ago

@jpe316 Is this example missing a version_name parameter in the deployment configuration.

It looks like for a controlled rollout(preview) scenario we are using version_name for adding new versions but the examples in the deployment_config for authentication are not using the same. Could you please confirm if this is required for other calls to the endpoint too?

djpugh commented 4 years ago

@RohitMungi-MSFT - it's in there correctly in the example, but the default deployment config doesn't require one I believe (or at least it allows the same name as the service name, which leads to issues with e.g. update calls)

RohitMungi-MSFT commented 4 years ago

@djpugh Could you please confirm if using the same name for endpoint_name and version_name in deployment config when you are deploying the model fails further updates when you update the version of the endpoint?

djpugh commented 4 years ago

It fails when you e.g. update to enable app_insights or change auth

RohitMungi-MSFT commented 4 years ago

@jpe316 Could you please help to check if using the same name for version and service name is allowed as it fails updates when they are the same?

PeterCLu commented 4 years ago

Hi @djpugh, the product team is aware of this bug and is working on a fix. I'll proceed to #please-close this issue.

https://dev.azure.com/msdata/vienna/_workitems/edit/727132/?triage=true