search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.29k stars 21.47k forks source link

Snipped based setup discrepencies #54254

Closed yohny closed 4 years ago

yohny commented 4 years ago

The snipped setup code sample on this doc page is different than the sample in app insight's readme.md on github (https://github.com/Microsoft/ApplicationInsights-js#snippet-setup-ignore-if-using-npm-setup)

Similar thing happened before, see #48152

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

mrbullwinkle commented 4 years ago

@yohny thanks for reporting this, I will take care of this.

mrbullwinkle commented 4 years ago

assign:mrbullwinkle

mrbullwinkle commented 4 years ago

Also just to answer your original question this is what was updated in the snippet: https://github.com/microsoft/ApplicationInsights-JS/pull/1258. Pinging @MSNev to confirm that the snippet updates from the SDK repo readme should be added to any references to the snippet on docs.microsoft.com? (I can put the changes in now, but just wanted to confirm).

MSNev commented 4 years ago

Hi Michael,

I’m in the process of updating the docs to include the new snippet along with additional documentation about an except report that the new snippet can send

https://github.com/MicrosoftDocs/azure-docs-pr/pull/114205

Cheers

Nev

From: Michael Bullwinkle notifications@github.com Sent: Wednesday, May 6, 2020 5:47 PM To: MicrosoftDocs/azure-docs azure-docs@noreply.github.com Cc: Nev Wylie Nev.Wylie@microsoft.com; Mention mention@noreply.github.com Subject: Re: [MicrosoftDocs/azure-docs] Snipped based setup discrepencies (#54254)

Also just to answer your original question this is what was updated in the snippet: microsoft/ApplicationInsights-JS#1258https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FApplicationInsights-JS%2Fpull%2F1258&data=02%7C01%7Cnev.wylie%40microsoft.com%7C481ae46c43454d48a9fe08d7f2202eb7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637244092344532129&sdata=A06nFZB7Ij1ViaLwopLS0uALB0uLk0JhnNYBZ5kk7dc%3D&reserved=0. Pinging @MSNevhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMSNev&data=02%7C01%7Cnev.wylie%40microsoft.com%7C481ae46c43454d48a9fe08d7f2202eb7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637244092344532129&sdata=yS0GbfqYC%2FH5iI0vmVaMJ8PdCe%2B%2BkNJhF9Y9Fqr%2F9PY%3D&reserved=0 to confirm that the snippet updates from the SDK repo readme should be added to any references to the snippet on docs.microsoft.com? (I can put the changes in now, but just wanted to confirm).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F54254%23issuecomment-624965392&data=02%7C01%7Cnev.wylie%40microsoft.com%7C481ae46c43454d48a9fe08d7f2202eb7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637244092344542088&sdata=tAAcU955%2BGGnmqrqu3XY%2FcJovc9%2FofUJPJWlPC7ME8k%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANCUCVIZXLP74PM7SM4WVK3RQIAJDANCNFSM4M2Y2IAA&data=02%7C01%7Cnev.wylie%40microsoft.com%7C481ae46c43454d48a9fe08d7f2202eb7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637244092344542088&sdata=P7OsGBVdess8J5FSav9bMfWzU%2Be5loNE2%2BssT0%2F1EZo%3D&reserved=0.

mrbullwinkle commented 4 years ago

This change was made live 11 days ago with this PR: Update JS

mrbullwinkle commented 4 years ago

please-close