MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.25k stars 21.42k forks source link

Provide more accurate information about versioning for in-flight instances #9152

Closed SimonLuckenuik closed 4 years ago

SimonLuckenuik commented 6 years ago

I consider this topic has being very important, easy to forget and tricky to debug, so I would like to have more information to prevent any issues. By reading the document, it sounds that once you go in Production with your code, it should not change at all since any small logic change is breaking for the replay. My remarks are around the fact that I don't want to lose data and keep my in-fligh instances running, considering that some workflows we have will be running for weeks.

For in-flight instances and versioning:


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

mimckitt commented 6 years ago

@SimonLuckenuik Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

SimonLuckenuik commented 4 years ago

@cgillum Could you please point me to the updated documentation?

cgillum commented 4 years ago

@SimonLuckenuik I'm impressed that you're still interested in following up on this docs issue even after ~515 days (apparently this was the oldest still-open docs issue for Functions)! :) I just checked and the updates should be published now. You can find the updated content here: https://docs.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-versioning.

You can also see the diff here: https://github.com/MicrosoftDocs/azure-docs/commit/1ce14d7eb0e434a4634b1879fbb129bb18eb1707#diff-422d3f2958314dc5fe55203073f37052

You may be slightly disappointed because I didn't make all the updates you requested. I tried to fit in as much as I could efficiently, though at the same time I wanted to be careful about providing too much guidance. My worry is that providing too much information about in-place updates may cause more folks to attempt them (and shoot themselves in the foot). I'd rather try to encourage readers to go down the side-by-side deployment path.

I'm open to updating this information further if you think it's necessary. If so, please open a new issue and can follow up there.

FYI @anthonychu

SimonLuckenuik commented 4 years ago

@cgillum, I just raised a follow-up issue on versioning directly in the Durable Functions repo to have proper visibility. It would be nice if some developers could share how they are handling versioning as well.