search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.25k stars 21.42k forks source link

Incorrect github repository secret for ACR #95488

Closed clarenceb closed 1 year ago

clarenceb commented 2 years ago

In section: https://docs.microsoft.com/en-us/azure/azure-arc/kubernetes/tutorial-gitops-flux2-ci-cd#create-github-repository-secrets

This secret isn't used but we are told to create it:

AZURE_VOTE_IMAGE_REPO | The full path to the Azure Vote App repository, for example azurearctest.azurecr.io/azvote -- | --

The script buildContainerTemplate.sh fails as it expects an environment variable called "AZ_ACR_NAME".

Instead we should create a repository secret like so:

AZ_ACR_NAME| The name of the Azure Container Registry resource to publish the azure vote container images, for example arc-demo-acr -- | --

In https://github.com/Azure/arc-cicd-demo-src/blob/master/.github/workflows/az-vote-cicd.yml#L17 we should change:

AZ_ACR_NAME: gitopsflowacr

to:

AZ_ACR_NAME: ${{ secrets.AZ_ACR_NAME }}

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

VikasPullagura-MSFT commented 2 years ago

@clarenceb Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

VikasPullagura-MSFT commented 2 years ago

@eedorenko Can you please check and add your comments on this doc update request as applicable.

rayoef commented 1 year ago

reassign:JnHs

JnHs commented 1 year ago

Hi @clarenceb, first of all let me apologize for the extremely long time to respond. Your suggestions are appreciated and we've made the changes you suggested. Thank you for taking the time to help us improve the docs, and again, sorry for the long delay.

please-close