search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.2k stars 21.34k forks source link

Incorrect method shown for local testing with AzureClient #96842

Open ryankmcintyre opened 2 years ago

ryankmcintyre commented 2 years ago

This page shows using LOCAL_MODE_TENANT_ID from "@fluidframework/azure-client" when setting up the connection, but LOCAL_MODE_TENANT_ID doesn't exist. Maybe it did in a prior version of azure-client.

The correct method to configure and create an AzureClient for local testing seems to be the method shown here.

Document details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Sandeg-MSFT commented 2 years ago

@ryankmcintyre Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

Sandeg-MSFT commented 2 years ago

@hickeys Can you please check and add your comments on this doc update request as applicable.

jonverrier commented 1 year ago

Hi,

I also encountered this issue . It’s quite important in terms of uptake, as anyone new to Fluid is going to hit it.

I believe the answer is 1) as the OP points out, use the linked document. LOCAL_MODE_TENANT_ID Is indeed not supported or relevant. 2) the definition of IUser does not include ‘name’, which seems to be required to run the service in local mode. I had to kludge this with an ‘any’ parameter to the InsecureTokenProvider including the definition.