search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.2k stars 21.36k forks source link

'NotificationHubs app' source link in the overview does not reflect the current document. #9808

Closed msivers closed 6 years ago

msivers commented 6 years ago

In the overview it states... "'The finished code is available in the NotificationHubs app sample.." but the link is to an old sample and does not reflect the contents of this document. It is the old GCM approach and not the newer FCM approach described in this document.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

YutongTie-MSFT commented 6 years ago

@msivers Thanks for the feedback! We are currently investigating and will update you shortly.

dimazaid commented 6 years ago

Hello - Thanks for the feedback, we will look into updating this soon.

pauloortins commented 6 years ago

I pushed a PR to fix it (https://github.com/Azure/azure-notificationhubs-samples/pull/53)

BryanTrach-MSFT commented 6 years ago

@msivers We will now proceed to close the thread. Please let us know if you have any further questions or concerns. Thank you for the heads up.

pauloortins commented 6 years ago

Is my PR going to be accepted?

krunalc commented 6 years ago

code is still not updated and thread has been closed. Why? Pls update the source code to match with the article content asap for this article to be relevant.