MicrosoftDocs / composer-docs

Public sync of existing composer-docs-pr repo
Creative Commons Attribution 4.0 International
2 stars 5 forks source link

Add references to xxxExpression and schema docs #194

Closed davhdavh closed 2 years ago

davhdavh commented 2 years ago

This page adequately explains how to make a very simple one, but it lacks references to figure out how to make a more complicated one.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

JonathanFingold commented 2 years ago

Added a couple more links. Changes should be visible later today.

davhdavh commented 2 years ago

Thanks.

I have dug a bit more into this subject, and I still think this article is vastly lacking in resources to continue making more complex custom actions.

  1. The demo class inherits from Dialog, but there is no reference to that anywhere, or any explanations what other alternatives are available. It is also really weird that the schema says it "$role": "implements(Microsoft.IDialog)",, but the Dialog class does not in fact inherit from anything.
  2. Nor is the flow really explained to make the developer understand what is actually going on.
  3. How to read and write User state?
  4. How to read and write Dialog state?
  5. There should be a note that setting runtimeSettings is only when doing it in an external library.
  6. The magic incantation for storing the result should really be explained (dc.State.SetValue(this.ResultProperty.GetValue(dc.State), result);).
  7. Default values (also for enums)?