sethbrenith
commented
7 months ago Looking great, thanks! I have a couple of comments on parts that you didn't change in the article "Record heap snapshots using the Memory tool", which you're welcome to add to this pull request or leave alone for now.
- The section named "Look up color coding" doesn't render with color or describe any colors.
- The section "Constructor (group) entries in the heap profiler" has some inaccuracies. I've never seen "(roots)" or "(global property)" in that list, and the description for "(array)" is incorrect. I also recently got rid of the category named "(closure)" and "(regexp)", though the current Stable and Beta versions still show those names. Here's a list I wrote describing the weird names that show up in the Summary. I also shared that list with Sofia (the upstream documentation writer), who said she'll update the upstream docs soon.
captainbrosset
learn-build-service-prod[bot]
Rendered articles for review:
These articles are a bit hard to understand, sometimes give information that's not really actionable for web developers, and could use an update.
AB#48649923