Closed captainbrosset closed 7 months ago
Looking great, thanks! I have a couple of comments on parts that you didn't change in the article "Record heap snapshots using the Memory tool", which you're welcome to add to this pull request or leave alone for now.
- The section named "Look up color coding" doesn't render with color or describe any colors.
Removed this entire section which was just very confusing to me. I couldn't recognize anything from the docs when looking at an actual snapshot.
- The section "Constructor (group) entries in the heap profiler" has some inaccuracies. I've never seen "(roots)" or "(global property)" in that list, and the description for "(array)" is incorrect. I also recently got rid of the category named "(closure)" and "(regexp)", though the current Stable and Beta versions still show those names. Here's a list I wrote describing the weird names that show up in the Summary. I also shared that list with Sofia (the upstream documentation writer), who said she'll update the upstream docs soon.
I've changed the entire table based on your excellent summary.
Learn Build status updates of commit fa67896:
This comment lists only the first 25 files in the pull request. For more details, please refer to the build report.
For any questions, please:
Learn Build status updates of commit dc711be:
This comment lists only the first 25 files in the pull request. For more details, please refer to the build report.
For any questions, please:
Rendered articles for review:
These articles are a bit hard to understand, sometimes give information that's not really actionable for web developers, and could use an update.
AB#48649923