MicrosoftDocs / ef-core-for-beginners

Project for Entity Framework Core for Beginners video series
Creative Commons Attribution 4.0 International
88 stars 58 forks source link

[BUG]: Line Endings should be LF for installSQLtools.sh #11

Closed Snailedlt closed 1 year ago

Snailedlt commented 1 year ago

When trying to open the repo in vscode through the Dev Container: Open Folder in Container... command, I received an error. Turned out the way to fix the error was to change the line endings of the file (thanks ChatGPT!), which could be done in VSCode by clicking on the CRLF symbol in the bottom right corner and selecting LF instead of CRLF. I'm not sure if this data can be saved in the repo or not, but if it can, it could potensially save others from hours of troubleshooting: image image image

ChatGPT conversation showing the error and ChatGPT's answers: https://sharegpt.com/c/Eb5jO4b

Snailedlt commented 1 year ago

Maybe we can make git do the opposite of this? image

Snailedlt commented 1 year ago

Aha, you can set up consistent line endings. Documentation here: https://code.visualstudio.com/docs/devcontainers/containers#_working-with-git

CamSoper commented 1 year ago

Thanks for this issue! I've run into this before with dev containers, I just forgot to include a .gitattributes this time.