MicrosoftDocs / feedback

📢 docs.microsoft.com site feedback
https://learn.microsoft.com
Creative Commons Attribution 4.0 International
239 stars 160 forks source link

Include nullability annotations #2218

Open thomaslevesque opened 4 years ago

thomaslevesque commented 4 years ago

Is your feature request related to a problem? Please describe. C# 8 introduced nullable reference types, and recent versions of .NET Core / .NET Standard make use of this feature. For instance, String.IsNullOrEmpty accepts a string?. But this is not reflected in the documentation.

Describe the solution you'd like It would be nice to indicate which parameters can be null, using the normal C# syntax (i.e. annotate the type with ?, like for nullable value types)

Describe alternatives you've considered N/A

Additional context N/A

thomaslevesque commented 4 years ago

As a bonus, it might be useful to include additional nullability annotations, such as [AllowNull], [NotNullWhen], etc.

BillWagner commented 4 years ago

@dendeli-msft This should probably be assigned to @mimisasouvanh and possibly @joelmartinez

When will the API docs begin reading the new annotations that have been added to the .NET Core APIs?

mairaw commented 4 years ago

log-suggestion

orcabot commented 4 years ago

🚀 ATTENTION: Internal request logged.

mimisasouvanh commented 4 years ago

@thomaslevesque Thank you for logging this issue. We are tracking it internally and will keep you posted on the progress.

thomaslevesque commented 4 years ago

Thanks @mimisasouvanh