search

MicrosoftDocs / microsoft-365-community

Microsoft 365 community contributed documentation https://docs.microsoft.com/microsoft-365/community/
MIT License
194 stars 167 forks source link

Update query-string-url-tricks-sharepoint-m365.md #995

Closed maggierui closed 1 week ago

maggierui commented 3 weeks ago

Please use this template to ensure easier processing of your pull request

Category

For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.

(DELETE THIS PARAGRAPH AFTER READING)

Related issues

If this fixes (should close) or references an issue, please add the issue number here. When you type the hashtag symbol (#), a list of potential issues will pop up from which you can choose. This helps those maintaining the issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.

(DELETE THIS PARAGRAPH AFTER READING)

Contents of the Pull Request

Please describe the changes in this PR. Try to give enough details so the person reviewing it to merge it can make a good decision about your content.

(DELETE THIS PARAGRAPH AFTER READING)

Guidance

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.

Please target your PR to master branch. Released documents are in live branch.

(DELETE THIS PARAGRAPH AFTER READING)

learn-build-service-prod[bot] commented 3 weeks ago

Learn Build status updates of commit b80059a:

:white_check_mark: Validation status: passed

File Status Preview URL Details
Community/query-string-url-tricks-sharepoint-m365.md :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

sympmarc commented 3 weeks ago

Thanks for the update, @maggierui! Good addition.

You have one mistake in what you added:

You can find out the internal filed name by going to [List Settings]...

I don't think you need the word field there in any case. Would you mid fixing that so I can accept the PR? I'd propose it read:

The internal name is not always the column name. You can find out the internal name by going to List Settings, choosing the column, and looking after the &Field= parameter in the URL. That's using a query string URL to help you make a query string URL!

maggierui commented 3 weeks ago

Thanks for the update, @maggierui! Good addition.

You have one mistake in what you added:

You can find out the internal filed name by going to [List Settings]...

I don't think you need the word field there in any case. Would you mid fixing that so I can accept the PR? I'd propose it read:

The internal name is not always the column name. You can find out the internal name by going to List Settings, choosing the column, and looking after the &Field= parameter in the URL. That's using a query string URL to help you make a query string URL!

Thanks @sympmarc for the feedback. Can you let me know why the word field is not needed? To provide a little background on why I am working on this article: I am the SharePoint content portfolio manager under Magic for LMC and SMC SharePoint content. I normally work in Office-SharePoint-pr repo on learn.microsoft.com, and the SMC-Marvel repo on support.microsoft.com. One of our org's primary OKRs for this FY is to make sure our content is fresh. Any content that was reviewed 365 days ago is considered "unfresh." This month our freshness PowerBI report for SharePoint content somehow pulled this article in and marked it as "older than 365 days", which is considered unfresh. So I reviewed the entire article by testing all query strings, and this is the only place where I feel it may cause users' confusion, by saying "internal column name" instead of referring directly to the query variable of internalFieldName I wasn't sure whether I should have used internalFieldName or internal field name but I do think it is necessary to refer to exactly how this field is used in the query string. I would like to learn your thoughts on this. Thank you.

maggierui commented 3 weeks ago

@sympmarc I see you added a label "Back to submitter" without explanation on why you think it is a mistake by including "field" - would you mind explaining the reason here? Thank you.

sympmarc commented 1 week ago

I'm so sorry I didn't reply, @maggierui. I was just talking to @pamgreen-msft, which reminded me I hadn't followed up with you. Again, my apologies.

I was thinking in the UI, users don't ever see the world "field", just "column". (There may be exceptions, but I can't think of any.)

That said, the world field is used in this very article in things like FilterField. It just shows how inconsistent the UI is from the internal, more developer-focused language.

What caught me up in the first place was that it said "filed". :) Let's go ahead with your change.

learn-build-service-prod[bot] commented 1 week ago

Learn Build status updates of commit b090e28:

:white_check_mark: Validation status: passed

File Status Preview URL Details
Community/query-string-url-tricks-sharepoint-m365.md :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

maggierui commented 1 week ago

I'm so sorry I didn't reply, @maggierui. I was just talking to @pamgreen-msft, which reminded me I hadn't followed up with you. Again, my apologies.

I was thinking in the UI, users don't ever see the world "field", just "column". (There may be exceptions, but I can't think of any.)

That said, the world field is used in this very article in things like FilterField. It just shows how inconsistent the UI is from the internal, more developer-focused language.

What caught me up in the first place was that it said "filed". :) Let's go ahead with your change.

Thank you so much @sympmarc for merging my change and for explaining your thoughts. 💯