search

MicrosoftDocs / mslearn-aks-deployment-pipeline-github-actions

Sample code for the MS Learn module for AKS with GitHub Actions
Creative Commons Attribution 4.0 International
18 stars 677 forks source link

Problems in init.sh #19

Open ondrelogin opened 1 year ago

ondrelogin commented 1 year ago

Lines 39 and 40 the sed commands. When I ran the script I got the errors ( <acr-name> and <dns-name> where the actual values).

sed: can't read s+!IMAGE!+<acr-name>/contoso-website+g: No such file or directory
sed: can't read s+!DNS!+<dns-name>+g: No such file or directory

I'm assuming the intent of the commands is to replace the azure values but as we proceed through the tutorial that is done via helm anyway. So I think that these commands should be removed.

Copy/Paste error on the echo on line 47

Currently

echo "-> AKS Cluster Name: $ACR_NAME"

Should be

echo "-> AKS Cluster Name: $AKS_NAME"

so the output would be

-> AKS Cluster Name: contoso-video
fcasamento commented 1 year ago

Thanks for letting me know, I was doing this lab and the problem still persists.