MicrosoftDocs / mslearn-aks-deployment-pipeline-github-actions

Sample code for the MS Learn module for AKS with GitHub Actions
Creative Commons Attribution 4.0 International
17 stars 670 forks source link

Issues with init.sh #3

Open Mod0700 opened 3 years ago

Mod0700 commented 3 years ago

The init.sh file has the following issues:

On line# 25 and 26, the export command is not able to assign the right value to the ACR_USERNAME and ACR_PASSWORD variables because the 'az acr credential show ... ' commands are not between .

On line# 38, the ACR_USERNAME variable does not has a '$' sign before that. So, instead of printing the value, it is just printing the variable name. On line# 40, the value to displayed should be $AKS_NAME and not $ACR_NAME

clambert commented 3 years ago

without this fix, this tutorial is broken for anyone who doesn't understand what is going on in the script file