search

MicrosoftDocs / msteams-docs

Source for the Microsoft Teams developer platform documentation.
https://aka.ms/teamsdev
Creative Commons Attribution 4.0 International
280 stars 501 forks source link

Carousel rendered in full msteams width #4394

Open Wajeed-msft opened 2 years ago

Wajeed-msft commented 2 years ago

Copied from: https://github.com/microsoft/botbuilder-dotnet/issues/5903 Posted by: @JordyGit

Details:

Adaptive Card property, see Documentation here: "msTeams": { "width": "full" },

Carousel made with: MessageFactory.Carousel

Is your feature request related to a problem? Please describe. Adaptive cards can use the msteams full witdth property to be rendered bigger in teams, alto using the same cards in a carousel or adding the property manually to a carousel, the carousel keeps being rendered smaller.

Describe the solution you'd like Carousels rendered wider if the property is present or when the adaptive cards in the carousel have the property.

Describe alternatives you've considered /

Additional context /

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ghost commented 2 years ago

Hi Wajeed-msft! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

Meghana-MSFT commented 2 years ago

@jordygit - We have informed the concerned team and the team is looking into it.

Meghana-MSFT commented 2 years ago

@jordygit - We got an update from the engineering team that they are deploying a hotfix to make the carousel width aligning with the older version. however, "full width" flag in carousel adaptive cards will be taken care later. Hence we do not have any ETA to share. I will keep you posted if there is any update.

Meghana-MSFT commented 2 years ago

The hot fix has been deployed. We tested and its rendering fine. image

Meghana-MSFT commented 2 years ago

This issue has been fixed and we have verified the fix. Attaching a screenshot of carousel cards with and without full width. Could you please check once and confirm the fix?

image

juanmanuelpuhl commented 2 years ago

@Meghana-MSFT For Teams desktop and Teams browser it's working fine now, but. if I open the app in a popup (in desktop) then the carousel is showed smaller (I tried with and without the Full option for width). Is this case a known issue?

Meghana-MSFT commented 2 years ago

@juanmanuelpuhl We will check this at our end and get back to you.

Meghana-MSFT commented 2 years ago

We see the size is same in a popup as well, attaching screenshots of the same, could you please confirm if you are referring to the same issue ?

Normal view : image Popout chat view : image

ghost commented 2 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 3 days. It will be closed if no further activity occurs within 3 days of this comment.

JordyGit commented 2 years ago

I have checked and can confirm the carousels are still not full width and in some cases even worse than before (unusable!).

I'll post some more examples very soon.

image

JordyGit commented 2 years ago

I have investigated it further.

Full width works perfect in private and group conversations for as well normal cards as carousels on the Teams Desktop App (1.5.00.12969 (64-bit))! Also everything including carousels work perfectly in the IOS Teams App. Thanks for that!

But it seems to still have issues in Teams/Channels for carousels while normal cards do work fine there with full width in the Desktop App. In some cases the carousel also doesn't slide as it should and has weird behavior in a Team/Channel in the Desktop App. See the GIFS I'll add below.

image

carousel offsets 2

carousel offsets

Meghana-MSFT commented 2 years ago

We will check these scenarios and reopen the bug as well.

ghost commented 2 years ago

Hi Wajeed-msft! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

ghost commented 2 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 3 days. It will be closed if no further activity occurs within 3 days of this comment.

Wajeed-msft commented 2 years ago

@JordyGit - removed tag due to which this issue was marked as inactive.

Meghana-MSFT commented 2 years ago

@JordyGit - We are able to repro this issue on Desktop and web apps. We have informed the engineering team and team will look into this. We will keep you posted on the updates.