MicrosoftDocs / msteams-docs

Source for the Microsoft Teams developer platform documentation.
https://aka.ms/teamsdev
Creative Commons Attribution 4.0 International
289 stars 513 forks source link

Improvement/Features request on messaging extension #6316

Closed tomqmr closed 1 year ago

tomqmr commented 2 years ago

During the development of our messaging extension, we found diverses things that works in certain context and not in others, or that can be improved so here is the list :

In chats we can click on the openURL button without sending the card in the conversation, but it is not working on channels.

In dark mode, the fields are not really visible compared to light, maybe it could be more delimited.

It could be really useful to tap Enter on keyboard to submit forms (like the ones on top of this).

ghost commented 2 years ago

Hi tomqmr! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

Nivedipa-MSFT commented 2 years ago

@tomqmr - We have tested this using below sample. https://github.com/microsoft/BotBuilder-Samples/tree/main/samples/csharp_dotnetcore/51.teams-messaging-extensions-action.

At our end the openURL is working in compose area for channel also.

And for dark mode the fields are clearly visible. image

You can raise an uservoice for below features.

  1. Enter shortcut to submit forms
  2. Tap Enter on keyboard to submit forms (like the ones on top of this).
ghost commented 2 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 3 days. It will be closed if no further activity occurs within 3 days of this comment.

ChetanSharma-msft commented 2 years ago

@tomqmr - Hope you are doing well !!

Please let us know whether you are still facing the issue? If not, shall we close the issue?

tomqmr commented 2 years ago

@ChetanSharma-msft Hi ! Sorry for the delay.

I'll open an user voice for the enter shortcut to submit forms.

For the fields form visibility in dark mode, I can't really agree on the "clearly visible" but that's ok it's only for comfort.

But for the main issue, I can confirm that openURL actions on card in compose area are not working in channels, see : openUrlChannel

It works well once I send it, but before it is not working (works well on conversation)

ChetanSharma-msft commented 2 years ago

@tomqmr - Thanks for reporting this issue.

You mean, it's working from conversation (After posting the card) but not working in Teams Channels in Compose Area ? Do you have same behavior in 1:1 personal chat as well?

Are you facing this issue in Teams Desktop Client or in Web?

tomqmr commented 2 years ago

@ChetanSharma-msft Yes exactly, sorry I confused conversation and personnal chat, so here's the 4 cases :

In channels :

In personnal chats :

Also I'm facing this issue both in Teams Desktop client and web

ChetanSharma-msft commented 2 years ago

@tomqmr - Thanks for sharing the details. Is there any specific URL format that you are using for openURL actions or any public URL?

I hope you are using Adaptive Card?

We will try it from our end and get back to you.

tomqmr commented 2 years ago

@ChetanSharma-msft No i can reproduce it with any other URL.

And for these ones I'm using "heroCard" from CardFactory, maybe the issue is proper to this type ?

ChetanSharma-msft commented 2 years ago

@tomqmr - We will try it using HeroCard/Adaptive Card. Meanwhile, can you please try it using Adaptive Card once ?

sayali-MSFT commented 2 years ago

@tomqmr -We are tried this scenario with the hero card in Teams channel. It's working fine from our end. Microsoft Teams Version 1.5.00.19202 (64-bit)-E

https://user-images.githubusercontent.com/93527375/178490518-d8bc8329-be82-400a-b229-ad286acf0d28.mp4

tomqmr commented 2 years ago

@sayali-MSFT Ok, I added a new action to my extension with this :

"context": [ "compose"],

And I agree, it is working well (with same url as my scenario that doesn't work) I thought the issue was general so I didn't add many details to my scenario, but in fact it seems to be in a very specific case, so here is more infos :

I assume that your action has the same context as the one I created to test the issue, but my real action is like this :

{
                    "id": "blabla",
                    "context": [
                        "message"
                    ],
                    "description": "blabla",
                    "title": "blabla",
                    "type": "action",
                    "fetchTask": true,
                    "initialRun": false,
                    "parameters": [
                        {
                            "name": "",
                            "title": ""
                        }
                    ]
                },  

As you can see it is with "context": [ "message"] And the issue might come from this. Here's my scenario :

Can you please retry it but with an action with context : ["message"] and tell me if you reproduce it ?

ChetanSharma-msft commented 2 years ago

@tomqmr - We will try it as per your provided changes & get back to you.

sayali-MSFT commented 2 years ago

@tomqmr -Could you please share the manifest json,So that we can try it from our end?

tomqmr commented 2 years ago

@sayali-MSFT manifest.zip

Nivedipa-MSFT commented 2 years ago

@tomqmr - We have tried your scenario and able to repro your issue. First we have added context : ["message"] and also fetchTask = true. On opening popup on submit action we have return hero card on compose area. We are also facing same issue. OpenURL is not working.

We have raised a bug for this. We will keep you posted if there are any updates.

Nivedipa-MSFT commented 2 years ago

@tomqmr - Engineering team has confirmed that openUrl in card won't work in compose box, it's meant to show a preview to the user.

ghost commented 2 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 3 days. It will be closed if no further activity occurs within 3 days of this comment.

tomqmr commented 2 years ago

@tomqmr - Engineering team has confirmed that openUrl in card won't work in compose box, it's meant to show a preview to the user.

Ok i can understand that but it does work on personal chat and in channel, just not in my case with action on messages, so was it supposed to work at first or is it a bug that this is working when it should not ?

Thanks

Nivedipa-MSFT commented 2 years ago

@tomqmr - Do you mean it used to work in personal chat and in channel in compose box while previewing?

tomqmr commented 2 years ago

@Nivedipa-MSFT Yes, and it is still working (as you can see on the gif), so I don't really understand your message "Engineering team has confirmed that openUrl in card won't work in compose box" because it actually works, just not in a specific case ... openUrlComposeBox

Nivedipa-MSFT commented 2 years ago

@tomqmr - Yes, you are right. Only for this specific scenario it's not working. We are checking this with engineering team. We will update you soon.