search

MicrosoftDocs / openapi-docs

Creative Commons Attribution 4.0 International
12 stars 28 forks source link

Building from source should be parameterized #11

Closed baywet closed 8 months ago

baywet commented 11 months ago

When using the following instructions on WSL, it fails as it uses the win-x64 option. We should parameterize this setting.

https://learn.microsoft.com/en-us/openapi/kiota/install#build-from-source Originally created by @sebastienlevert at https://github.com/microsoftdocs/openapi-docs-pr/issues/22

nagarajDeveloper commented 9 months ago

I think RID is already parameterized with keyword "-r". But as in document it is directly mentioned for win-x64 it might lead confusion for non-windows platform users. To be more specific platform use case, updated document with RID values explicitly, with pull request : https://github.com/MicrosoftDocs/openapi-docs/pull/25

nagarajDeveloper commented 8 months ago

Hi All,

I see that #11https://github.com/MicrosoftDocs/openapi-docs/issues/11 Closed as completed via #25https://github.com/MicrosoftDocs/openapi-docs/pull/25. But I didn't see latest changes at site https://learn.microsoft.com/en-us/openapi/kiota/install [https://opengraph.githubassets.com/4250f3e4ce1a8f99007f413890c9d8a3ca179248174efb3ce0179024e48d65f9/MicrosoftDocs/openapi-docs/issues/11]https://github.com/MicrosoftDocs/openapi-docs/issues/11 Building from source should be parameterized · Issue #11 · MicrosoftDocs/openapi-docshttps://github.com/MicrosoftDocs/openapi-docs/issues/11 When using the following instructions on WSL, it fails as it uses the win-x64 option. We should parameterize this setting. https://learn.microsoft.com/en-us/openapi/kiota/install#build-from-source ... github.com

Is there anything pending yet ?

Regards, Nagaraj

From: Vincent Biret @.> Sent: Wednesday, October 11, 2023 6:17 PM To: MicrosoftDocs/openapi-docs @.> Cc: nagarajDeveloper @.>; Comment @.> Subject: Re: [MicrosoftDocs/openapi-docs] Building from source should be parameterized (Issue #11)

Closed #11https://github.com/MicrosoftDocs/openapi-docs/issues/11 as completed via #25https://github.com/MicrosoftDocs/openapi-docs/pull/25.

— Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/openapi-docs/issues/11#event-10618242080, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG6WQGGCH5AAGRTZBO3IXSLX62IMNANCNFSM6AAAAAA3ADGICY. You are receiving this because you commented.Message ID: @.***>

baywet commented 8 months ago

@jasonjoh when you have a couple of minutes, can you trigger a refresh please?

jasonjoh commented 8 months ago

Done. Changes should show up in a few minutes.