MicrosoftDocs / terminal

Creative Commons Attribution 4.0 International
470 stars 177 forks source link

`"commandPalette", "launchMode": "commandLine"` doesn't work from the command palette #578

Closed JannesVU closed 5 months ago

JannesVU commented 2 years ago

The setting: { "command": "commandPalette", "launchMode": "commandLine", "keys": "" } does not work for my current version of the terminal (Windows Terminal Version: 1.14.2281.0)


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

mattwojo commented 2 years ago

Thanks for bringing this to our attention @JannesVU. We're investigating. @zadjii-msft -- does launching command palette into the command line work? We tried it but are having some trouble.

zadjii-msft commented 2 years ago

(sorry, seems like my mail filters are overly aggressive)

Well, that kinda makes sense. If you're already in the command palette, then toggling the command palette will close it, rather than change the mode (which is what's expected here).

FWIW, binding this to a key does work:

        {
            "command":
            {
                "action": "commandPalette",
                "launchMode": "commandLine"
            }, 
            "keys": "ctrl+shift+."
        },

I suppose technically, this should move to be a bug on the Terminal repo - the commandPalette action with a different mode than the current one should clear the input and switch to that mode. That makes sense.

But alternatively, you could just backspace the >, and presto, command-line mode.

zadjii-msft commented 5 months ago

Moved over to https://github.com/microsoft/terminal/issues/17114