search

MicrosoftDocs / terminal

Creative Commons Attribution 4.0 International
470 stars 177 forks source link

Document 'activeOnly' value for 'showCloseButton' property. #660

Closed kovdu closed 1 year ago

kovdu commented 1 year ago

See https://github.com/microsoft/terminal/pull/15237 which still needs to get merged though.

So don't know when this MR needs to be merged then :-) but at least the new value is already documented.

learn-build-service-prod[bot] commented 1 year ago

Learn Build status updates of commit 88336be:

:white_check_mark: Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/themes.md :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

learn-build-service-prod[bot] commented 1 year ago

Learn Build status updates of commit 182d3a1:

:white_check_mark: Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/themes.md :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

learn-build-service-prod[bot] commented 1 year ago

Learn Build status updates of commit d396f95:

:white_check_mark: Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/themes.md :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please:

nguyen-dows commented 1 year ago

Hi @kovdu, thanks for working on the issue and writing the docs! :) I looks like your code PR was merged last week so it should make it to our 1.18 release.

What I will do is merge this docs PR into the release-1.18 branch instead of main. Once our 1.18 Preview release comes out in a few weeks then we will push the entire release-1.18 branch into main then move it to live so that the world can see these docs :)

Does this make sense?

kovdu commented 1 year ago

Yes. That makes totally sense @nguyen-dows ! Thanks for providing the extra context 😀.

learn-build-service-prod[bot] commented 1 year ago

Learn Build status updates of commit d396f95:

:white_check_mark: Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/actions.md :white_check_mark:Succeeded View
TerminalDocs/customize-settings/profile-advanced.md :white_check_mark:Succeeded View
TerminalDocs/customize-settings/themes.md :white_check_mark:Succeeded View

For more details, please refer to the build report.

For any questions, please: