search

MicrosoftDocs / terminal

Creative Commons Attribution 4.0 International
468 stars 170 forks source link

useAtlasEngine Default Wrong? #721

Closed ThomasMConnors closed 7 months ago

ThomasMConnors commented 9 months ago

"experimental.useAtlasEngine" is listed with a default of FALSE.

However, the current JSON Schema shows the default to be true:

    "useAtlasEngine": {
      "description": "Windows Terminal 1.16 and later ship with a new, performant text renderer. Set this to false to revert back to the old text renderer.",
      "type": "boolean",
      "default": true

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

DHowett commented 9 months ago

Thanks for the report! As with much of our schema stuff, this one is ... not the greatest.

In preview builds, Atlas defaults to true. In stable builds, it defaults to false.

Up until recently, we didn't have a way to point the different versions of Terminal at different versions of the schema (whoops!) Because of that, we just shipped it with the "average" default values for whatever was in the preview channel for a given Terminal version.

zadjii-msft commented 7 months ago

Furthermore, in https://github.com/microsoft/terminal/pull/16277, we'll be making atlas the default for both stable and preview branches (starting with 1.19 Stable).

(We can't really x-link this issue and that PR across repos, but this will be officially closed by that PR)