MicrosoftDocs / terminal

Creative Commons Attribution 4.0 International
467 stars 170 forks source link

Match Profile Value Type ("matchProfile" --> "matchProfiles") #750

Closed SpongeBobCodePants closed 2 months ago

SpongeBobCodePants commented 4 months ago

Type of issue

Typo

Feedback

When I attempted to use the "Match Profile" option like this:

{ "type": "matchProfile", "source": "Microsoft.Terminal.Wsl" }

I received the following error: WindowsTerminal_Fh2ezT5f89

I noted that the error adds an 's' to the end of "matchProfile". This worked correctly:

{ "type": "matchProfiles", "source": "Microsoft.Terminal.Wsl" }

This typo appears five times @ https://learn.microsoft.com/en-us/windows/terminal/customize-settings/appearance

Thank you!

Page URL

https://learn.microsoft.com/en-us/windows/terminal/customize-settings/appearance

Content source URL

https://github.com/MicrosoftDocs/terminal/blob/main/TerminalDocs/customize-settings/appearance.md

Author

@cinnamon-msft

Document Id

7df17a2d-a108-ef6f-fc93-9f2c6100dc7a

DHowett commented 3 months ago

AH! Thanks for catching this!

mattwojo commented 2 months ago

Looks like @wcruz-br caught this as well and filed this PR with a fix: https://github.com/MicrosoftDocs/terminal/pull/745

Just merged it. Thank you both!