search

MicrosoftDocs / visualfsharpdocs

Frozen documentation repository for legacy MSDN Content for Visual F#
https://msdn.microsoft.com/en-us/visualfsharpdocs/conceptual/visual-fsharp
Creative Commons Attribution 4.0 International
102 stars 111 forks source link

Small fix in incorrect code example on up- and downcasting #308

Closed abelbraaksma closed 6 years ago

abelbraaksma commented 6 years ago

The let keyword was missing in the example.

Also, **upcast** *expression* and **downcast** *expression* does not render correctly on the Microsoft website of this page (i.e., here: https://msdn.microsoft.com/en-us/visualfsharpdocs/conceptual/casting-and-conversions-%5Bfsharp%5D) as can be seen in this screenshot, the space is missing:

image

@cartermp, @KevinRansom or anybody, is this an error with the renderer at Microsoft? Because in Markdown and on Github it looks just fine.

dend commented 6 years ago

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/conceptual/casting-and-conversions-[fsharp].md :white_check_mark:Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

cartermp commented 6 years ago

@abelbraaksma What you're fixing makes up the conceptual doc set for F#, which has been migrated to docs.microsoft.com/dotnet/fsharp.

I applied this fix to that doc here: https://github.com/dotnet/docs/pull/4838

The rendering works on docs, so I think we can close this PR. Since these map to the legacy docs set (which, unfortunately, is still live for the FSharp.Core API reference), any changes to conceptual F# content should go to the dotnet/docs repo.

abelbraaksma commented 6 years ago

@cartermp, I remembered something like that, but then I saw this "Contribute" button on each document and I decided to just go for it ;), assuming it still applied.

It's rather confusing to have two sets of docs that are nearly identical. Maybe, while the original docs remain in place, we can put a banner on top of them, something like "This is an outdated version, please see more recent version here"?

cartermp commented 6 years ago

Yeah, it's quite confusing indeed. Once we work out the finnicky issues in representing F# syntax on the docs API infrastructure, we'll redirect all URLs from this doc set to that one. Unfortunate, and somewhat lengthy, point-in-time issue 😢