search

MicrosoftDocs / windows-dev-docs

Conceptual and overview content for developing Windows apps
Creative Commons Attribution 4.0 International
692 stars 1.2k forks source link

Confusing text #5156

Open ericlaw1979 opened 2 weeks ago

ericlaw1979 commented 2 weeks ago

Type of issue

Other (describe below)

Feedback

If the search provider endpoint is using CORS, the Windows search client will send out a HTTP OPTIONS request before each GET request.

This doesn't make sense-- the domain relationship between the search client and the target service is what determines whether CORS is in use-- it's not up to the service to decide. Either CORS is required, or it's not used.

Page URL

https://learn.microsoft.com/en-us/windows/apps/develop/search/search-providers

Content source URL

https://github.com/MicrosoftDocs/windows-dev-docs/blob/docs/hub/apps/develop/search/search-providers.md

Author

@stevewhims

Document Id

c6d5b252-f5c3-2500-1f7c-c3f201c8eff3

stevewhims commented 1 week ago

Hi, @ericlaw1979. You use the term "target service", which doesn't appear anywhere in this topic. So will readers know what that refers to? Does "target service" mean "search provider"?

If you could get me the exact text that should appear in this section then I can get that updated; or else feel free to create a PR on the private content repo here, and assign that to me.

Thanks! -Steve