MicrosoftDocs / windows-powershell-docs

This repo is used to contribute to Windows 10, Windows Server 2016, and MDOP PowerShell module documentation.
Creative Commons Attribution 4.0 International
446 stars 598 forks source link

Error in example #3005

Open ReedK-DFT opened 2 years ago

ReedK-DFT commented 2 years ago

[Enter feedback here]

The example: Enable-NetFirewallRule -DisplayName "Network Discovery"

Returns an error that no rules are found with that display name.

Also, just enabling the firewall rules is not enough to allow network discovery. You still have to go through the GUI and enable network discovery from the advanced options page. The state of that radio button does not change with any powershell command I can find.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

BWMerlin commented 1 year ago

I have had a quick look at this and maybe the example could be updated to change the name of the given example of "Network Discovery". I don't think is suppose to represent the literal name of the firewall rule that controls Network Discovery but rather represent an example of what a firewall rule might be called.

The example could be updated to something like "Network Discovery (LLMNR-UDP-In)" or one of the other many rules that may be present that are used for firewalling network discovery or the example could be change to something more oblivious that it is suppose to be a place holder name for a firewall rule such as "My Example Firewall rule".

Another option (which is probably the better option) could be to change the description provided to something like "This example enables a firewall rule that is named "Network Discovery" by specifying the localised name of the rule.

officedocspr5 commented 11 months ago

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.

As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.

If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.

With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.

Here's what the new experience looks like.

Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.

First, select whether the article was helpful:

Image showing a dialog asking if the article was helpful with yes and no answers.

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful Article was unhelpful
Image showing a dialog asking how the article was helpful with several options. Image showing a dialog asking how the article wasn't helpful with several options.

Finally, select Submit and you're done!