MicrosoftDocs / windows-powershell-docs

This repo is used to contribute to Windows 10, Windows Server 2016, and MDOP PowerShell module documentation.

Creative Commons Attribution 4.0 International

441 stars 592 forks source link

Update Get-WindowsReservedStorageState.md #3831

Closed SteveDiAcetis closed 3 months ago

SteveDiAcetis commented 3 months ago

Fixing example, it fails with -Online.

PR Summary

Removed the -Online parameter from the example as it causes error. It doesnt apply per discussion with engineering owner.

PR Checklist

[x] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[x] Summary: This PR's summary describes the scope and intent of the change.
[x] Contributor's Guide: I have read the contributors guide.
[x] Style: This PR adheres to the style guide.

officedocspr commented 3 months ago

Thanks for submitting your pull request. To improve the quality of your content and make sure all errors are resolved, we recommend that you use the PubOps publishing process.

Add the Sign off label when you think your PR is ready to merge. A PR reviewer either merges it, or adds the Back to Submitter label with a comment about what needs to be fixed and sends it back to you.
If you need to update your content per the PR reviewer feedback, add the Sign off label again.
Your content is published live during one of the next publishing cycles, which are weekdays at 10:30 AM Pacific Time and 3:30 PM Pacific Time.

If you have a question, post it on the Ask an Admin support channel.

learn-build-service-prod[bot] commented 3 months ago

Learn Build status updates of commit 3f08ba4:

:white_check_mark: Validation status: passed

File	Status	Preview URL	Details
docset/winserver2022-ps/dism/Get-WindowsReservedStorageState.md	:white_check_mark:Succeeded	View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

SteveDiAcetis commented 3 months ago

@mestew not sure if you are able to review and merge this small change. Not urgent.

mestew commented 3 months ago

@SteveDiAcetis Does this bit below need to be pulled out of the cmdlet despcription as well?

Gets the current state of reserved storage. This command is supported with the online Windows image.

Thanks for checking out the details on this with engineering. Let me know about the desription and I can get this merged for ya

SteveDiAcetis commented 3 months ago

The description is correct. I will add 'only' to it. Because only online, the parameter for online (versus offline image) isn't needed.

learn-build-service-prod[bot] commented 3 months ago

Learn Build status updates of commit 0ef629c:

:white_check_mark: Validation status: passed

File	Status	Preview URL	Details
docset/winserver2022-ps/dism/Get-WindowsReservedStorageState.md	:white_check_mark:Succeeded	View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

mestew commented 3 months ago

@SteveDiAcetis saw the new change come through. Thanks so much. I'll handle getting this merged in.