MicrosoftDocs / windowsserverdocs

Public content repository for Windows Server content.
Creative Commons Attribution 4.0 International
1.36k stars 1.79k forks source link

Incorrect Powershell Snippets #6894

Open DeMoB opened 1 year ago

DeMoB commented 1 year ago

The powershell snippets are incorrect on this page for setting the user agent for Chrome on Windows and OSX

It's written:

Set-AdfsProperties -WIASupportedUserAgents (Get-ADFSProperties | Select -ExpandProperty WIASupportedUserAgents) + "Mozilla/5.0 (Windows NT)" and Set-AdfsProperties -WIASupportedUserAgents (Get-ADFSProperties | Select -ExpandProperty WIASupportedUserAgents) + "Mozilla/5.0 (Macintosh; Intel Mac OS X)"

But should be:

Set-AdfsProperties -WIASupportedUserAgents ((Get-ADFSProperties | Select -ExpandProperty WIASupportedUserAgents) + "Mozilla/5.0 (Windows NT") and Set-AdfsProperties -WIASupportedUserAgents ((Get-ADFSProperties | Select -ExpandProperty WIASupportedUserAgents) + "Mozilla/5.0 (Macintosh; Intel Mac OS X")

Additionally the screenshot shows the result of this command as having added the user agent "Chrome", which is no longer accurate to the commands above.


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

jd1984 commented 1 year ago

Wish I had found this before struggling with https://github.com/MicrosoftDocs/windowsserverdocs-pr/issues/5490 !

jd1984 commented 12 months ago

@billmath Please can you correct and update this one? It just needs the extra left parenthesis and a new screenshot adding.

Thank You

robinharwood commented 3 weeks ago

We hugely appreciate your contribution, feedback, and support to our technical documentation.

We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.

All issues will be migrated by Thursday 29th August 2024.

Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.