MicrosoftDocs / winrt-api

WinRT reference content for developing Microsoft Universal Windows Platform (UWP) apps
Creative Commons Attribution 4.0 International
231 stars 496 forks source link

Links to generic types with specific type arguments are unusable #1183

Closed konsoletyper closed 5 years ago

konsoletyper commented 5 years ago

There are lots of links like these: IAsyncOperationWithProgress<IBuffer, ulong>, where the whole text is a single link. This makes this link unusable, since in case of APIs that return interfaces like IAsyncOperation, IVector, etc, I often interested in type argument's API rather than in generic type API. Compare this to Files.lines example in javadoc, where Stream and String are separate links pointing to Stream and String class documentation correspondingly. So in case of IAsyncOperationWithProgress<IBuffer, ulong> there should be three links (IAsyncOperationWithProgress, IBuffer, ulong).


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

stevewhims commented 5 years ago

Hi, @konsoletyper, thanks for raising this issue. For this topic, I refactored the link (and the "See also") in the way you suggested. I did the same for another 34 topics in this namespace where the parameter types are non-primitive. ~Steve

konsoletyper commented 5 years ago

Hello. I don't think this issue can be closed. I don't think you should change documentation text to resolve it. I believe you guys generate documentation in the way similar to Javadoc, JSDoc, doxygen, etc. And I believe that text like

Returns
IAsyncOperationWithProgress<IBuffer, ulong>

Is generated automatically from method signature. So the proper way is to update you documentation generation tool, not specific documentation pages. Please, reopen this issue and fix documentation generator.

stevewhims commented 5 years ago

You're right, @konsoletyper, getting that improved systematically would be great. So, I've filed an internal work item tracking that work. And I'll monitor it along with the others in my list. I'll go ahead and re-close here, since I'm taking care of it internally.

In this case, the writer had added links manually, so I think it was worth fixing/improving those.

Thanks again! ~Steve

konsoletyper commented 5 years ago

Thanks! Hope they'll able to fix documentation generator soon.