MicrosoftDocs / winrt-api

WinRT reference content for developing Microsoft Universal Windows Platform (UWP) apps
Creative Commons Attribution 4.0 International
231 stars 499 forks source link

Corrections to RectHelper and SizeHelper's definition of "empty" #2355

Closed mcooley closed 1 year ago

mcooley commented 1 year ago

RectHelper and SizeHelper use a definition of "Empty" which matches .NET's System.Windows.Rect.Empty. A Rect or Size with Width == 0 or Height == 0 is not "empty" because it is not the Empty value.

Note that this information also applies to the Microsoft.UI.Xaml version of these methods. I assume I'll need to open a separate PR against winapps-winrt-api for that; please let me know if there's a different process which is preferred.

prmerger-automator[bot] commented 1 year ago

@mcooley : Thanks for your contribution! The author(s) have been notified to review your proposed change.

ShannonLeavitt commented 1 year ago

@jwmsft

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

label:"aq-pr-triaged"

@MicrosoftDocs/public-repo-pr-review-team

jwmsft commented 1 year ago

@mcooley, thanks for these fixes. I'll take care of copying them over to Microsoft.UI.Xaml so you won't need to worry about it.

sign-off

prmerger-automator[bot] commented 1 year ago

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

jwmsft commented 1 year ago

sign-off

prmerger-automator[bot] commented 1 year ago

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @