search

MicrosoftEdge / Demos-old

Open source and interoperable demos for Microsoft Edge Dev site
https://dev.windows.com/en-us/microsoft-edge/testdrive/
Other
437 stars 268 forks source link

Check video.error for null on MSE/EME demo #147

Open hsivonen opened 8 years ago

hsivonen commented 8 years ago

Steps to reproduce: 1) Navigate to https://developer.microsoft.com/en-us/microsoft-edge/testdrive/demos/eme/ in Firefox. 2) In the list of videos on the left, click any video that's not the currently-selected one.

Actual results: A message "TypeError: video.error is null" is logged.

Expected results: No error.

Additional info: The error location is line 729 in demo.js, which reads:

if (video.error.msExtendedCode) {

That line should null-check video.error before trying to check the msExtendedCode property on it.

hsivonen commented 8 years ago

CC @mohmoto

dstorey commented 8 years ago

CC @molant

molant commented 8 years ago

@mohmoto what do you want to do with this? As they say in https://github.com/webcompat/web-bugs/issues/1855 Firefox doesn't support WebM content in EME yet.

mohmoto commented 8 years ago

I'll fix this. It's pretty low pri though as it's in an error path.