search

MicrosoftEdge / DevTools

Feedback and discussions about Microsoft Edge Developer Tools
MIT License
151 stars 49 forks source link

Transparent icon for some extensions that supply a DevTools Panel #237

Open bengry opened 3 months ago

bengry commented 3 months ago

It seems like some extensions are getting a transparent icon in their devtools panel. E.g. EditThisCookie CleanShot 2024-03-20 at 20 17 46@2x

Trying to debug this a bit it seems like the <devtools-icon> element has the correct value for the icon source as it's [name], and in the root <span> (inside the shadow root) a wrong --icon-url CSS variable is injected. In this case it's: url(chrome-extension://fngmhnnpilhplaeedifhccceomclgfbg/img/icon_32x32.png.svg), which leads to a file that doesn't exist. I'm not sure why the .svg suffix is automatically appended.

Furthermore, if I manually remove the .svg suffix, a mask in the same shape as the icon is displayed, instead of the icon: CleanShot 2024-03-20 at 20 21 42@2x

I think adding the extension's icon is an Edge-specific feature, as in Chrome this is what I get: CleanShot 2024-03-20 at 20 23 02@2x

OS: macOS 14.4 (23E214) Edge version: Version 122.0.2365.92

AB#49588478

captainbrosset commented 3 months ago

Extension icons have been a bit of a challenge to get right lately. So thank you for filing this issue and investigating already. I'll make sure our dev team prioritizes this in our backlog.

bengry commented 3 months ago

Extension icons have been a bit of a challenge to get right lately. So thank you for filing this issue and investigating already. I'll make sure our dev team prioritizes this in our backlog.

Thanks @captainbrosset! It would also be nice if we could just turn them off completely. I'm not sure how useful they are, especially when each has its own size and look. Unlike the built-in panels which look & feel uniform.

captainbrosset commented 3 months ago

It would be nice if each and every panel had its own icon. This would help make things look consistent, and some people like to use icons to quickly identify tools. But I agree with the risk of them having their own different look.

bengry commented 3 months ago

It would be nice if each and every panel had its own icon. This would help make things look consistent, and some people like to use icons to quickly identify tools. But I agree with the risk of them having their own different look.

I agree in principle, but you can't force the hand of extension developers, especially when most of them think of Edge specially (which is the only browser that has this out of the Chromium browsers I looked at).

That's why I suggested an option to turn off extension icons - so that the consumer has the control.