MicrosoftEdge / DevTools

Feedback and discussions about Microsoft Edge Developer Tools
MIT License
151 stars 49 forks source link

Debugger pausing on ignore listed files #243

Open royalone opened 3 months ago

royalone commented 3 months ago

I have a bunch of files (mainly minified libraries) that I have added to the ignore list. When I open these files in the Sources tab, there is a banner at the bottom telling me that This script is on the debugger's ignore list

Adding breakpoints to these files will pause execution, and also checking the pause on caught/uncaught exceptions breakpoint options will pause in these ignore listed files.

This is mainly an issue to me when I want to pause on exceptions in my own code, but the pausing is polluted by all my libraries throwing and catching exceptions all the time.

Edge version: Version 123.0.2420.81 (Official build) (64-bit)

Let me know if I can provide more info Thanks

AB#50057122

captainbrosset commented 2 months ago

Thank you for filing.

Adding breakpoints to these files will pause execution,

I'm not clear here on whether this should occur or not. I'll take a deeper look in a minute.

checking the pause on caught/uncaught exceptions breakpoint options

This should definitely not happen.

captainbrosset commented 2 months ago

I can confirm the first one is intentional: even when you add a script to the ignore list, manually setting breakpoints within that script will still trigger those breakpoints. Manual breakpoints override the ignore script setting.

captainbrosset commented 2 months ago

I just tested the second one: "checking the pause on caught/uncaught exceptions breakpoint options", and things seem to work fine for me. When I add the script to the ignore list, and then select the options, script execution does not pause within the ignored script.

@royalone could you please check again and make sure this is broken on your end? And, if so, please provide a test that we can use to reproduce the issue locally.

royalone commented 2 months ago

Digging a bit deeper, it's the ignore list general exclusion rules, specifically Content scripts injected by extensions that doesn't seem to be working for me.

captainbrosset commented 2 months ago

Thanks for the additional investigation details. I'll make sure this issue shows up on our team's radar for prioritization.