MicrosoftEdge / WebView2Samples

Microsoft Edge WebView2 samples
830 stars 460 forks source link

Changing content under Evergreen Bootstrapper link #150

Open georg-eckert-zeiss opened 1 year ago

georg-eckert-zeiss commented 1 year ago

Hi devs, I tried the sample under SampleApps/WV2DeploymentWiXBurnBundleSample/Bundle.wxs. It contains the following part:

<ExePackage
  Id="DownloadAndInvokeBootstrapper"
  Name="Install WebView2 Runtime"
  Cache="no"
  Compressed="no"
  PerMachine="yes"
  Vital="no"
  DownloadUrl="https://go.microsoft.com/fwlink/p/?LinkId=2124703"
  InstallCommand=" /silent /install"
  InstallCondition="NOT (REMOVE OR WVRTInstalled)">
  <RemotePayload
    ProductName="MicrosoftEdgeWebview2Setup"
    Description="Microsoft Edge WebView2 Update Setup"
    CertificatePublicKey="1392A8505C3B192F62311EA9005E49C1B5358F6B"
    Hash="82B42348804E8D82C773DC3391B691712BB1B388"
    Size="1815832"
    Version="1.3.135.41"/>
</ExePackage>

But under the given link https://go.microsoft.com/fwlink/p/?LinkId=2124703 I get a bootstrapper of version 1.3.167.21 with another file size and - of course - another hash. For that reason I am not able to check the file integrity, because the file is changing.

Is this wanted?

Best regards, Georg

PS: I guess it's the same issue as #65 PPS: Relates to my issue at WebView2Feedback.

georg-eckert-zeiss commented 1 year ago

I read the comment in #65. But isn't that a bad way of aquiring an installer hash, by downloading it and copying it from the downloaded file? Usually there is a second download for the MD5 or Sha512 hash or something like that. I expected the download link to link to an ever-same bootstrapper downloading the most current version of the software, thereby giving me a way to verify the integrity of the downloaded content (the way it's intended in a bundle installer).

Am I wrong?

What is the best way to get the evergreen bootstrapper with a bundle installer?

Best regards, Georg